Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch protection for main branch #2

Open
rasmi opened this issue Apr 7, 2022 · 2 comments
Open

Add branch protection for main branch #2

rasmi opened this issue Apr 7, 2022 · 2 comments

Comments

@rasmi
Copy link
Contributor

rasmi commented Apr 7, 2022

Require pull requests with review approvals to merge changes into the main branch.

@bion
Copy link
Contributor

bion commented Apr 14, 2022

I added branch protection to require PRs but would prefer we not require reviews for ease of updating developer docs

@rasmi
Copy link
Contributor Author

rasmi commented Apr 14, 2022

I disabled it temporarily until we can figure out how to allow gitbook-bot to bypass the branch protection (it is useful for some team members to make edits from GitBook directly and right now there's no obvious way to do that with branch protection enabled). I will keep an eye out for vandalism in the meantime! But agreed, branch protection + no reviews for members seems like a good setup. We can also set up teams in the CiviForm GitHub org to better manage permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants