Terminal mode: When checking if there is a process attached to terminal, it should not block neovim instance

[Civitasv]

Currently, I use these codes to check if there is a process is finished, which is need to chain callback.

https://github.com/Civitasv/cmake-tools.nvim/blob/3e5f768977a7825e70335feff2cfac56e54ac33b/lua/cmake-tools/terminal.lua#LL542C1-L560C6

But this will block neovim instance, we should find a non-blocking or async way to check this.

[rohit-kumar-j]

Note to people using cmake_always_use_terminal=true

If you do not chaining of commands and vim.wait() to block your neovim instance, you can hit the CTRL C once or twice after launching the terminals.
This will lose the chained commands, but you can access neovim while the CMakeTask is running.

---

The reason we added this option is because:

1. We want to keep the build output from all the commands, along with the commands persistent.
2. And to view the exact commands that are being sent to the terminal on each run.
3. We want to give full access to the user (users who donot use CMake Presets) to set/modify specific cmake flags to the terminal directly in the command line for quick experimentation.

Kindly provide feedback on this feature... 👋

[rohit-kumar-j]

Currently, I use these codes to check if there is a process is finished, which is need to chain callback.

https://github.com/Civitasv/cmake-tools.nvim/blob/3e5f768977a7825e70335feff2cfac56e54ac33b/lua/cmake-tools/terminal.lua#LL542C1-L560C6

But this will block neovim instance, we should find a non-blocking or async way to check this.

(Posible solution?)...

If we do a background non-blocking vim.wait() that looks inside the build directory every n milliseconds until the currently running cmake produces the CMakeCache.txt or something like that which tells the status of the cmake process is completed, once it finds this (effectively a more verbose on_success() condition), maybe even the timestamp of the file... We can then chain the next command with a small delay.

We will need to create new functions for checking status of files like how the codemodel targets are obatined...

Since the solution is cmake specific solution, I think this will be a decent solution without the explicit on_success() callback.

[rohit-kumar-j]

I've opened a question here: https://discourse.cmake.org/t/is-there-a-way-to-check-when-any-cmake-task-has-finished-purely-from-the-filesystem-build-directory/8271

[Civitasv]

Okay, hopefully someone can anwser it. 😄

[rohit-kumar-j]

Seems like this can be accomplished by writing a dummy query into a file.

@Civitasv, do you have any idea how we may do this?

[Civitasv]

I've researched some plugins about terminal, cannot find a suitable solution to get notified when terminal executes commands successfully. But I find another way, See it at #63.

[rohit-kumar-j]

Nice! That is a simple and effective solution :D