Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake variants: default option support #95

Closed
Arniiiii opened this issue Jul 26, 2023 · 4 comments
Closed

cmake variants: default option support #95

Arniiiii opened this issue Jul 26, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Arniiiii
Copy link

Right now if use cmake-variants, you still is requested to choose among a lot of options, but there's no default option, though in cmake-variants we write it.

A possible solution: add the default option to the list from :CMakeSelectBuildType to position 1

Alternative solution: if entered no number, choose default.

Possible problems: checking if there's default for every choice.

@Arniiiii Arniiiii added the enhancement New feature or request label Jul 26, 2023
@Civitasv
Copy link
Owner

Civitasv commented Aug 6, 2023

Actually, you only need to select once, we support session save and load.

@Arniiiii
Copy link
Author

Arniiiii commented Aug 7, 2023

Actually, you only need to select once, we support session save and load.

You are right about the capability.
Though, I'm about simplifying even further: if someone have to select something, he can press 0 or nothing to set default option. It will make redundant for developers to find that specific option among hundreds and thousands of options, if they just want default proposed by cmake-variants.* .

@Civitasv
Copy link
Owner

Civitasv commented Dec 9, 2023

I've enabled default option, use the latest commit.

@Arniiiii
Copy link
Author

It works! Great thanks to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants