-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
15588 lines (10556 loc) · 577 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
commit 9949364ea761ab7efa2a9930ec7718f966a740c0
Author: Matthieu Herrb <matthieu@herrb.eu>
Date: Thu Jul 30 21:36:22 2020 +0200
libX11 1.6.10
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
commit 1703b9f3435079d3c6021e1ee2ec34fd4978103d
Author: Matthieu Herrb <matthieu@herrb.eu>
Date: Fri Jul 24 21:09:10 2020 +0200
Change the data_len parameter of _XimAttributeToValue() to CARD16
It's coming from a length in the protocol (unsigned) and passed
to functions that expect unsigned int parameters (_XCopyToArg()
and memcpy()).
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Todd Carson <toc@daybefore.net>
commit 1a566c9e00e5f35c1f9e7f3d741a02e5170852b2
Author: Todd Carson <tc@daybefore.net>
Date: Fri Jul 24 20:59:32 2020 +0200
Zero out buffers in functions
It looks like uninitialized stack or heap memory can leak
out via padding bytes.
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
commit 2fcfcc49f3b1be854bb9085993a01d17c62acf60
Author: Todd Carson <tc@daybefore.net>
Date: Fri Jul 24 20:22:44 2020 +0200
Fix more unchecked lengths
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
commit 388b303c62aa35a245f1704211a023440ad2c488
Author: Todd Carson <tc@daybefore.net>
Date: Fri Jul 24 19:36:51 2020 +0200
fix integer overflows in _XimAttributeToValue()
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
commit 0e6561efcfaa0ae7b5c74eac7e064b76d687544e
Author: Todd Carson <tc@daybefore.net>
Date: Fri Jul 24 19:33:30 2020 +0200
Fix signed length values in _XimGetAttributeID()
The lengths are unsigned according to the specification. Passing
negative values can lead to data corruption.
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
commit 2b7598221d87049d03e9a95fcb541c37c8728184
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Wed Jul 22 15:19:58 2020 -0700
Fix spelling/wording issues
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit f9e3378ebcfc79ff00591b8617a68e97580a741e
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Sun Jul 19 22:19:24 2020 +0200
xlibi18n: Fix converting horizline keysyms to UCS
U+23BA - U+23BD are meant to represent the scan lines, and U+2500 is
unified with scan line 5.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
commit 4385a84c4a79c1b60bf12839899a1544198de975
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Thu Jun 4 02:19:13 2020 +0200
Braille: Fix default lookup
cbb59d172 ('Braille: Fix typing quickly') broke the default lookup that
translates Braille keysym patterns to Braille Unicode patterns since it
rightfully clears brl_committing, but then we do not have it any more to
fill brl_committed.
This change saves the committed pattern so we can return it in the
default lookup.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
commit fb65b67169105c82c243f265e0f993cf72efdacd
Author: Marko Myllynen <myllynen@redhat.com>
Date: Fri Feb 28 13:59:36 2020 +0200
Update Finnish compose sequences for SFS 5966:2019 standard
U0219, U0218, U021B, U021A are now part of the standard.
Fixes #70 which was printed incorrectly in the earlier standard version.
commit 07724ce046348a21cc82a874853b14b9a285df75
Author: Tristan Miller <psychonaut@nothingisreal.com>
Date: Wed Sep 25 13:34:01 2019 +0200
Add acute accent compose sequences for Russian vowels.
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/104
Signed-off-by: Tristan Miller <psychonaut@nothingisreal.com>
commit 3ec9264d01a3a66c0fa0145a7c1db06a64be1507
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Sat Apr 25 14:40:54 2020 -0400
document an ancient performance problem (see Debian #954845).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 791c93816ce0520d54925b0b3ccbc29823370041
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Sat Apr 25 14:22:11 2020 -0400
update/correct function prototypes in manpages to match headers
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 844271305a28e87031562dfeb43defbea02960a2
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Apr 21 20:53:35 2020 -0400
reduce gcc-normal warnings using casts (no object change)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 53b59ddfc114a55d26e9717a1b4822f1b18c40ca
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Apr 21 18:13:22 2020 -0400
reduce gcc-normal warnings using casts (no object change)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 68c72a7341b114277ab232f2499ee3bd035af8a0
Author: Adam Jackson <ajax@redhat.com>
Date: Wed Dec 11 11:53:11 2019 -0500
Fix XTS regression in XCopyColormapAndFree
XCopyColormapAndFree/5 threw an assertion:
520|4 5 00014017 1 2|Assertion XCopyColormapAndFree-5.(A)
520|4 5 00014017 1 3|When a colourmap argument does not name a valid colourmap,
520|4 5 00014017 1 4|then a BadColor error occurs.
520|4 5 00014017 1 5|METH: Create a bad colourmap by creating and freeing a colourmap.
520|4 5 00014017 1 6|METH: Call test function using bad colourmap as the colourmap argument.
520|4 5 00014017 1 7|METH: Verify that a BadColor error occurs.
520|4 5 00014017 1 8|unexpected signal 6 (SIGABRT) received
220|4 5 2 15:05:53|UNRESOLVED
410|4 5 1 15:05:53|IC End
510|4|system 0: Abandoning testset: caught unexpected signal 11 (SIGSEGV)
More specifically:
lt-XCopyColormapAndFree: xcb_io.c:533: _XAllocID: Assertion `ret != inval_id' failed.
This bug was introduced (by following my advice, d'oh) in:
commit 99a2cf1aa0b58391078d5d3edf0a7dab18c7745d
Author: Tapani Pälli <tapani.palli@intel.com>
Date: Mon May 13 08:29:49 2019 +0300
Protect colormap add/removal with display lock
In that patch we moved the call to _XcmsCopyCmapRecAndFree inside the
display lock. The problem is said routine has side effects, including
trying to implicitly create a colormap in some cases. Since we don't run
the XID handler until SyncHandle() we would see inconsistent internal
xlib state, triggering the above assert.
Fix this by dropping and re-taking the display lock before calling into
XCMS.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
commit 7f46a38139f66fda734f3a6c445b84ea89c8f310
Author: Alex Henrie <alexhenrie24@gmail.com>
Date: Wed Jan 1 14:54:06 2020 -0700
Handle small final sigma in XConvertCase
lowercase: GREEK SMALL LETTER FINAL SIGMA (U+03C2)
uppercase: GREEK CAPITAL LETTER SIGMA (U+03A3)
This mapping was correct in UCSConvertCase, but the "legacy" mapping
must also be correct for Caps Lock to work with the final sigma key.
https://gitlab.freedesktop.org/xorg/lib/libx11/issues/5
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
commit a48787d3d155c8a09cead345f5055da30c1db537
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed Dec 11 14:12:27 2019 +1000
Handle ssharp in XConvertCase()
lowercase: LATIN SMALL LETTER SHARP S (U+00DF)
uppercase: LATIN CAPITAL LETTER SHARP S (U+1E9E)
The uppercase sharp s (XK_ssharp) is a relatively recent addition to unicode
but was added to the relevant keyboard layouts in xkeyboard-config-2.25
(d1411e5e95c)
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/issues/144
Alas, the CapsLock behavior was broken on the finnish layout (maybe others).
This was due to xkbcomp using XConvertCase() to determine whether a key
requires the type FOUR_LEVEL_ALPHABETIC or FOUR_LEVEL_SEMIALPHABETIC.
Let's make this function return the right lower/upper symbols for the sharp s
and hope that the world won't get any worse because of it.
https://gitlab.freedesktop.org/xorg/lib/libx11/issues/110
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit b8766a438461e20b5c6f7a6111b703d4cb71501f
Author: Raul Fernandes <rgfernandes@gmail.com>
Date: Wed Oct 9 18:39:26 2019 +0000
Use memcmp and memcpy
commit db7cca17ad7807e92a928da9d4c68a00f4836da2
Author: Adam Jackson <ajax@redhat.com>
Date: Wed Oct 9 13:41:29 2019 -0400
libX11 1.6.9
Signed-off-by: Adam Jackson <ajax@redhat.com>
commit f5ba2c632a4c84279bdd48c687271292f5dc4f87
Author: Dmitry Osipenko <digetx@gmail.com>
Date: Sat May 18 19:10:32 2019 +0300
Fix lockup in _XReply() caused by recursive synchronization
This patch is based on a suggestion made by Uli Schlachter in a comment
to the bug report https://gitlab.freedesktop.org/xorg/lib/libx11/issues/93.
Explanation of the bug (given by Uli Schlachter as well):
An error was received and handled. Since there was an error callback set,
Xlib unlocks the display, runs the error callback, and then locks the display
again. This goes through _XLockDisplay and then calls _XSeqSyncFunction.
On this "lock the thing"-path, Xlib notices that sequence numbers are close to
wrap-around and tries to send a GetInputFocus request. However, the earlier
calls already registered themselves as "we are handling replies/errors, do
not interfere!" and so the code here waits for "that other thread" to be done
before it continues. Only that there is no other thread, but it is this thread
itself and thus a deadlock follows.
The bug is relatively easy to reproduce on any desktop environment by
using actively a touchscreen input that supports multitouch, i.e. practically
all mobile devices are affected.
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/93
Suggested-by: Uli Schlachter <psychon@znc.in>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
commit 1f1ca0863fd81fd0538b104eb9d9841ddbc7c905
Author: Adam Jackson <ajax@redhat.com>
Date: Fri Sep 13 16:44:32 2019 -0400
xkb: Provide <X11/extensions/XKBgeom.h> ourselves
This header refers to libX11 types, it doesn't belong in xorgproto and
has been moved to legacy in 2019.2. Supply it ourselves.
commit edc7680ed5a03cedb5facf14693823455e12c29c
Author: Ross Burton <ross.burton@intel.com>
Date: Tue Aug 6 14:53:43 2019 +0100
src/util/Makefile: explicitly reset LINK to not use libtool
Simply looking at libtool redefines LINK globally to use libtool, which when
you're trying to cross-compile to Windows can cause complications.
As in src/util/ we're simply building a small binary for the build host, reset
LINK to the automake default so that the traditional compile/link steps occur
without libtool.
Also remove -all-static from LDFLAGS as that is a libtool-specific argument
intended to solve this problem.
Closes: #100
Signed-off-by: Ross Burton <ross.burton@intel.com>
commit f111bf3ac091a3a6d1f094172621d9d033c3833c
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Jul 30 16:53:27 2019 -0400
improve some formatting
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 1d0a6fe9126c7ce61c6648cabf43b2de4d6d3ba9
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Jul 30 15:49:09 2019 -0400
fix a substitution error from recent commit, e.g, "s/^\.EE/XDe/"
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 8fe8aafe7e9beffaff0460fe08354dfcde1efe98
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Jul 30 05:07:40 2019 -0400
split lines at sentence endings
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 6f2cbcea5d6dcd1df7ef309481cad1663284c061
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Jul 30 04:52:25 2019 -0400
trim trailing whitespace from manpages
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit 4abf482d8e6b0b1ae84e0f528e71066afd6d18b5
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Jul 30 04:36:24 2019 -0400
another fake-quote fix
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit c0f0651f2b4dfa9fef86d1374689220125631993
Author: Thomas E. Dickey <dickey@invisible-island.net>
Date: Tue Jul 30 04:34:54 2019 -0400
the last commit overlooked some fake-quote pairs
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
commit ef31143c9decda54b3ab2937d3300fcf5b493fd6
Author: Walter Harms <wharms@bfs.de>
Date: Mon Jul 29 18:50:19 2019 +0200
fix ``fake quotes'' in text
to remove the fake quotes replace them with propper
predefined macros \*(lq and \*(rq. this will allow
nroff to choose the propper characters when using ps etc.
Signed-off-by: Walter Harms <wharms@bfs.de>
commit 705027ea9b17d6552388d2067736ab4b0bf9dfb5
Author: Walter Harms <wharms@bfs.de>
Date: Mon Jul 29 18:27:12 2019 +0200
get rid of ``fake quotes''
these fake quotes are inside a comment and can be replaced with
some double quotes
Signed-off-by: Walter Harms <wharms@bfs.de>
commit fe46eb287106ad05538e896783a5cf877a4138df
Author: Walter Harms <wharms@bfs.de>
Date: Mon Jul 29 17:57:02 2019 +0200
remove all private macro defines
after converting everything to st. man page macros there is
no need to maintain X11 private nroff macros, so remove them.
Signed-off-by: Walter Harms <wharms@bfs.de>
commit b7f09ae19c9a098ecd545b4d4c45a6afe39a8764
Author: Walter Harms <wharms@bfs.de>
Date: Mon Jul 29 17:47:35 2019 +0200
Replace home-grown .Ds .De macro with man page .EX/.EE macro
Same pages use the man page .EX/.EE macro. Replace all occurences
of .De/.Ds with the std. macros to make the code better to maintain.
Signed-off-by: Walter Harms <wharms@bfs.de>
commit 951e772bc8d89bc62c4bbac14adc5d4f5027419f
Author: Walter Harms <wharms@bfs.de>
Date: Wed Jul 3 18:23:51 2019 +0200
fix TBL format
Signed-off-by: Walter Harms <wharms@bfs.de>
commit 4eb167f5aca4cca05a230c728ffdb4fd382a4e1e
Author: Walter Harms <wharms@bfs.de>
Date: Wed Jul 3 18:18:09 2019 +0200
replace home grown .ZN with std, .B and .BR
Replace the home grown macro .ZN with std. macros
from man macro paket. So we can get rid of the
definition an get a clean header.
Signed-off-by: Walter Harms <wharms@bfs.de>
commit 08e6b36292ebf01ba2dcc4a48ec371c6f5d13458
Author: Walter Harms <wharms@bfs.de>
Date: Sat Jun 22 18:33:48 2019 +0200
remove in-text macros
remove in-text macros an fix a few typos on the way.
hopefuly that will make maintenance more easy.
Signed-off-by: Walter Harms <wharms@bfs.de>
commit cb0e894fe9927b07bd9d97c067fd0d007accb105
Author: Walter Harms <wharms@bfs.de>
Date: Fri Jun 21 18:01:16 2019 +0200
note that we can handle kbd==NULL
Signed-off-by: Walter Harms <wharms@bfs.de>
commit 0327c427d62f671eced067c6d9b69f4e216a8cac
Author: Adam Jackson <ajax@redhat.com>
Date: Mon Jun 17 13:36:08 2019 -0400
makekeys: Detach ourselves from X headers entirely
Subsequent to a121b7b0c210efe10bf93453b29050282324c906 we are no longer
building makekeys with enough -I/foo/bar to find the X11 headers, so if
they're not in a system include path, things fail. Since this utility is
only needed at build time, there's no real reason to demand the X
headers be installed for both the build and target machines if cross-
compiling, we can just assume a vaguely ANSI environment instead.
Tested-by: Niclas Zeising <zeising@daemonic.se>
Reviewed-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
commit 57f0d421a1320090d3a4948181fe228d86cc8977
Author: Matt Turner <mattst88@gmail.com>
Date: Mon Jun 17 10:45:45 2019 -0400
libX11 1.6.8
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit 5464b302bc0c4a055d3eac06c6ab15e209ff7668
Author: Matt Turner <mattst88@gmail.com>
Date: Sun Jun 9 14:00:15 2019 -0700
Use AC_SYS_LARGEFILE
... and include config.h in makekeys.c to get the definition of
_FILE_OFFSET_BITS. Without it, libX11 can fail to build on a file
system with 64-bit inode numbers.
Bug: https://bugs.gentoo.org/550502
Bug: https://bugs.gentoo.org/616140
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit 33b9148a833ab2ea46e44871da3c031bf1b78f77
Author: Ran Benita <ran234@gmail.com>
Date: Thu Feb 13 20:55:08 2014 +0200
Compose.man: fix escaped hexadecimal char description
The man page says:
Strings may be direct text encoded in the locale for which the
compose file is to be used, or an escaped octal or hexadecimal
character code. Octal codes are specified as "\123" and
hexadecimal codes as "\0x123a".
But the grammar in the parser and the implementation say:
ESCAPED_CHAR ::= ('\\' | '\"' | OCTAL | HEX )
HEX ::= '\' (x|X) HEX_CHAR [HEX_CHAR]]
HEX_CHAR ::= (0|1|2|3|4|5|6|7|8|9|A|B|C|D|E|F|a|b|c|d|e|f)
So "\0x123a" -> "\x3a".
Signed-off-by: Ran Benita <ran234@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit d9b2cc35edf01e4f751a9ccb5ac185745184cec0
Author: ojab <ojab@ojab.ru>
Date: Mon Apr 24 20:12:17 2017 +0000
Compose sequences for rouble sign
Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout.
Signed-off-by: Slava Kardakov <ojab@ojab.ru>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 3f211616f6414bd9958566c0ca137e87a2b6df95
Author: Pavel Labath <pavelo@centrum.sk>
Date: Fri Nov 30 20:45:04 2012 +0100
Fix a leak in XCreateFontSet
a simple snippet like XFreeFontSet(d, XCreateFontSet(d, ...)) will generate lots of memory leaks,
as evidenced by the following valgrind output:
==983== HEAP SUMMARY:
==983== in use at exit: 39,409 bytes in 341 blocks
==983== total heap usage: 4,795 allocs, 4,454 frees, 489,086 bytes allocated
==983==
==983== 1,688 (136 direct, 1,552 indirect) bytes in 1 blocks are definitely lost in loss record
40 of 46
==983== at 0x4C2B042: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==983== by 0x56D5A93: add_codeset.clone.9 (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56D5FE0: load_generic (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56D7612: initialize (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56D7E75: _XlcCreateLC (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56F9A5F: _XlcUtf8Loader (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56DF815: _XOpenLC (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56B255A: XOpenOM (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56A665A: XCreateFontSet (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x4FCA80: conky::x11_output::create_gc() (x11.cc:746)
==983== by 0x4FC3B4: conky::x11_output::use_own_window() (x11.cc:602)
==983== by 0x4FAD42: conky::priv::own_window_setting::set(bool const&, bool) (x11.cc:92)
==983==
==983== LEAK SUMMARY:
==983== definitely lost: 136 bytes in 1 blocks
==983== indirectly lost: 1,552 bytes in 34 blocks
==983== possibly lost: 0 bytes in 0 blocks
==983== still reachable: 37,721 bytes in 306 blocks
==983== suppressed: 0 bytes in 0 blocks
This patch makes the leak dissappear (Well, at least the "definitely lost part". The "still
reachable" thingy remains). After some analysis, I've discovered that the XLCd structure is
destroyed improperly. The "constructor" is in lcGeneric.c, but the structure is destroyed using
code from lcPublic.c. I've found that changing the destructor call to _XlcDestroyLC executes the
correct code path, and I'm pretty sure this is correct (the object was constructed using
_XlcCreateLC, it make sense to destroy it using its conterpart).
So far I haven't observed any strange behaviour on my system caused by this change (although, I'm
not sure, how many programs actually use this function).
Signed-off-by: Pavel Labath <pavelo@centrum.sk>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 4645e219133458781e3fb48eaea6a74cccb1b9aa
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Tue Apr 30 14:39:06 2019 +0100
Avoid using libtool wrapper for makekeys
For Windows targets, libtool uses a wrapper executable, not a wrapper
script (see [1]), which it compiles with the host compiler. This
doesn't work when cross-compiling.
Since we don't actually need to link with anything, use the libtool flag
-all-static to tell it to stay completely out of this.
[1] https://www.gnu.org/software/libtool/manual/html_node/Wrapper-executables.html
commit 6886d9ba06826785a8ccb312c04ea82b91bb6a25
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Wed Apr 24 12:50:41 2019 +0100
Use EXEEXT_FOR_BUILD for makekeys
Use EXEXT_FOR_BUILD, to fix cross-compiling where EXEEXT differs from
EXEEXT_FOR_BUILD, such as when building for Windows from unix.
(Note: As written, this assumes EXEEXT_FOR_BUILD is always empty when
cross-compiling. There could be some elaborate autodetection for
EXEXT_FOR_BUILD, but for the moment, if you are cross-compiling from
Windows to Unix, you'll need to set EXEEXT_FOR_BUILD explicity...)
commit a121b7b0c210efe10bf93453b29050282324c906
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Tue Apr 30 14:30:41 2019 +0100
Remove makekeys dependency on X headers
This is the patch from https://bugs.freedesktop.org/show_bug.cgi?id=6669
by Pierre Ossman, reworked for master.
Avoid using LIBS (which are for host, but we don't need) and rewrite
makekeys slightly to avoid needing to include any X headers, which
avoids potentially having -I with host paths in CFLAGS, which can cause
standard headers e.g. stdio.h for the host to also be used, which can
break things...
commit cbb59d1727cb1bfcff91b54fd55f4139e360b7ab
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Fri Jun 7 23:35:33 2019 +0200
Braille: Fix typing quickly
On finishing releasing Braille keys, we should clear the just-commited
pattern, to reset the state to initial state, and avoid having to wait for
0.3s before typing the next pattern.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Tested-by: Jean-Philippe Mengual <jpmengual@hypra.fr>
commit 99a2cf1aa0b58391078d5d3edf0a7dab18c7745d
Author: Tapani Pälli <tapani.palli@intel.com>
Date: Mon May 13 08:29:49 2019 +0300
Protect colormap add/removal with display lock
This fixes a bug where concurrent threads call XCreateColormap and
XFreeColormap corrupting a linked list where colormap structures
are stored.
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/94
v2: handle XCopyColormapAndFree also (Adam Jackson)
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
commit fea80d03c381a4de379863c0d41f6d4c00f15e1e
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Wed Mar 13 13:12:20 2019 +0000
Add autoconf checks for headers we include for FIONREAD
Add autoconf checks for the extra headers we include to define FIONREAD.
This needs sys/socket.h on Cygwin, and none of the alternatives on
Windows.
commit 87c77a1e6d7034536e9d25ce24a667ebf53486a7
Author: Matthias Dieter Wallnöfer <matthias.wallnoefer@lugbz.org>
Date: Mon Mar 11 14:19:52 2019 +0000
locale.alias.pre - add the de_IT locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 568f77f414072506bbe48646637c872987c97e63
Author: Matthias Dieter Wallnöfer <matthias.wallnoefer@lugbz.org>
Date: Mon Mar 11 14:17:10 2019 +0000
locale.dir.pre - add the de_IT locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 38c0c92feaef7dc4a72920b1dd79872e6578086c
Author: Matthias Dieter Wallnöfer <matthias.wallnoefer@lugbz.org>
Date: Mon Mar 11 14:12:07 2019 +0000
compose.dir.pre - add de_IT locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 49f835611ba6ab82e68b7b851507931c142db7a5
Author: Matthias Dieter Wallnöfer <matthias.wallnoefer@lugbz.org>
Date: Tue Jan 29 15:34:34 2019 +0000
Update locale.alias.pre - introduce the de_LI aliases (equivalent to de_CH)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit ed669234d0cd5933618aa5fd2da697b59845b9be
Author: Matthias Dieter Wallnöfer <matthias.wallnoefer@lugbz.org>
Date: Tue Jan 29 15:28:18 2019 +0000
locale.dir.pre - fix the de_LI latin15 locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 82b5c1454a49333b4d94984d40db79cff386d37f
Author: Josh Triplett <josh@joshtriplett.org>
Date: Sun Feb 3 08:31:41 2019 +0100
compose.dir.pre: Give the C.UTF-8 locale a full set of UTF-8 compose sequences
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
commit 603c3ab25a692194805fd4b0c62afac8093897fe
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Mar 9 20:58:07 2019 -0800
Add missing close paren to XrmGetStringDatabase synopsis in man page
Fixes: commit 0642e99ac05afb0c
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 6590cc41e3c5c5c836a49a2c82774d7cc9ab3c85
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 11:12:27 2019 -0800
Include reallocarray.h in tarballs so "make distcheck" passes
Fixes: commit bcf7b5aa06c23aee
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit a4a7df06351ce9565d298a84547ff71f2d220fbf
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 11:04:41 2019 -0800
XlibInt.c: include headers needed for ioctl(...FIONREAD...) on Solaris
Fixes: commit 5538b3e4ae6dee
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 38ec04de7e537dde6b7b1eaca46b1a24fcdbc044
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 10:48:26 2019 -0800
specs/XKB: Fix misprint in documentation of XkbFreeGeomOverlayKeys()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/86
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23550
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 74f2f26811ae82b15dede31504b0eb541f7a3293
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 10:46:05 2019 -0800
specs/XKB: Fix misprint in documentation of XkbAllocGeomOverlayKeys()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/85
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23549
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 66b039a41690f076e962ac6bd46cca017360a7d1
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 10:44:15 2019 -0800
specs/XKB: Fix misprint in documentation of XkbAllocGeomOverlayRows()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/84
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23548
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit cdea0e840315171f8390adc63a2397ddf111eea4
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 10:38:08 2019 -0800
specs/XKB: Fix misprint in documentation of XkbGetNamedGeometry()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/82
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23520
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit c72d17ada98723cd9e03ddf06680a0e54b2c3089
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 23 10:30:32 2019 -0800
XkbAllocGeomOverlayKey man page should be named XkbAllocGeomOverlayKeys
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 05002b8aef9544c8545e0823a02cf14f335d2b68
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Feb 17 15:13:25 2019 -0800
Fix man page typo: XkbAllBellNotifyMask -> XkbAllBellEventsMask
Reported-by: Daniel Hahler <git@thequod.de>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 5538b3e4ae6dee32c47db9dfc85b07bbe7b90f6c
Author: Adam Jackson <ajax@redhat.com>
Date: Fri Mar 24 11:07:36 2017 -0400
_XDefaultIOError: Do better at detecting explicit shutdown
Currently, when the X server crashes or a client is disconnected with
XKillClient, you get a somewhat confusing error message from libX11
along the lines of:
XIO: fatal IO error 11 (Resource temporarily unavailable) on X server ":0"
after 98 requests (40 known processed) with 0 events remaining.
What's happening here is the previous recvmsg has thrown EAGAIN, since
the socket is non-blocking. In this case, check whether the socket has
any more data to read, and if not treat it like EPIPE.
Signed-off-by: Adam Jackson <ajax@redhat.com>
commit 6d2cde9633b5ee020cb60caea1cf61e090b86dd2
Author: Adam Jackson <ajax@redhat.com>
Date: Fri Mar 24 11:07:35 2017 -0400
_XDefaultIOError: Reformat to be less ugly
Signed-off-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 003e30a66a249f5c70b30d1c187385124cd4cdad
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue Jan 1 14:34:04 2019 -0800
Avoid use-after-free in _XimProtoSetIMValues()
Fixes gitlab issue #49
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 30656fd66ad47aeaca0bfc237a818f189554f07e
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue Jan 1 12:21:04 2019 -0800
Fix implicit conversion warnings in _XlcCreateDefaultCharSet
lcCharSet.c:187:50: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
tmp = Xmalloc(name_len + 1 + ct_sequence_len + 1);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../../include/X11/Xlibint.h:453:32: note: expanded from macro 'Xmalloc'
~~~~~~ ^~~~
lcCharSet.c:192:31: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
memcpy(tmp, name, name_len+1);
~~~~~~ ~~~~~~~~^~
lcCharSet.c:216:45: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
memcpy(tmp, ct_sequence, ct_sequence_len+1);
~~~~~~ ~~~~~~~~~~~~~~~^~
lcCharSet.c:183:16: warning: implicit conversion loses integer precision:
'unsigned long' to 'int' [-Wshorten-64-to-32]
name_len = strlen(name);
~ ^~~~~~~~~~~~
lcCharSet.c:184:23: warning: implicit conversion loses integer precision:
'unsigned long' to 'int' [-Wshorten-64-to-32]
ct_sequence_len = strlen(ct_sequence);
~ ^~~~~~~~~~~~~~~~~~~
lcCharSet.c:198:37: warning: implicit conversion loses integer precision:
'long' to 'unsigned int' [-Wshorten-64-to-32]
unsigned int length = colon - charset->name;
~~~~~~ ~~~~~~^~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 2e6300905784fa8adfcea019262ea58b3e1ed4ad
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue Jan 1 11:41:47 2019 -0800
Remove no-longer-used name variable in _XGetAtomName
Fixes gcc warning:
GetAtomNm.c: In function ‘_XGetAtomName’:
GetAtomNm.c:39:11: warning: unused variable ‘name’ [-Wunused-variable]
char *name;
^~~~
Introduced by commit 336c1e7a505698a8f3bcb6eb96dbbb8ed21ade96
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit f077871c2a12cf098b0c50572e112c6dc5e04de0
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Dec 29 11:39:29 2018 -0800
Fix out-of-tree builds after commit 8a62e26515e528bb47917ec4a55cc2b492419eeb
In-tree builds found reallocarray.h in $(top_builddir)/src but the
out-of-tree build didn't find it at all.
Reported-by: Emmanuele Bassi <ebassi@gmail.com> from GNOME continuous integration pipeline
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit ba7f7cc783672784bebc6e69349b55c6c75c1973
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Sep 27 18:35:27 2015 -0700
Convert src/xlibi18n to use reallocarray()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 336c1e7a505698a8f3bcb6eb96dbbb8ed21ade96
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Sep 26 11:12:47 2015 -0700
Replace Xmalloc+strcpy pairs with strdup calls
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 258a8ced681dc1bc50396be7439fce23f9807e2a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 19 11:58:50 2015 -0700
Replace _XkbTypedRealloc & _XkbClearElems with new _XkbResizeArray
Makes resizing & clearing more consistent and gets rid of some weird
quirks like always subtracting 1 from the size passed to _XkbClearElems
so it could always add 1 to the size passed in.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit f94273e2f4284040306b888e5ca0381ee00591af
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 19 09:47:29 2015 -0700
Add some missing allocation failure checks in src/xcms
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 76850471b4a5a6d30f5660234e87ec2772e7b426
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 19 09:33:21 2015 -0700
Convert src/xcms to use reallocarray()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 8a62e26515e528bb47917ec4a55cc2b492419eeb
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 19 09:24:02 2015 -0700
Convert src/XKB to use reallocarray()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 6d1dc1f6169ebf0ba71785d461bd98129c65c862
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Thu Jun 4 23:30:43 2015 -0700
Convert main src directory to use reallocarray()
commit bcf7b5aa06c23aee00af7999b58cb96a8571ac42
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Thu Jun 4 23:18:23 2015 -0700
Import reallocarray() from OpenBSD
Wrapper for realloc() that checks for overflow when multiplying
arguments together, so we don't have to add overflow checks to
every single call. For documentation on usage, see:
http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 9bdfe9c9af11d77d66e5ff651e82b20e695cb460
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon Nov 19 21:26:23 2018 -0800
Update README for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit c8bcc19970a2cc4ad337de1338c63a07325eefcd
Author: Albert Astals Cid <aacid@kde.org>
Date: Fri Nov 9 22:24:52 2018 +0100
locale.dir: Add ast_ES.UTF-8
With this patch xev properly reports
XLookupString gives 2 bytes: (c2 b4) "´"
for the dead_acute key when using the Asturian locale
commit 117bb310b44ce03802c91a70949eb58dcc702a3c
Author: Albert Astals Cid <aacid@kde.org>
Date: Fri Nov 9 22:18:43 2018 +0100
compose.dir: Add ast_ES.UTF-8
With this patch one can properly type dead keys like á when using the
Asturian locale
commit d7e22252d68258a63ca537827c99d0ac0bc4b9d8
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Nov 10 13:30:47 2018 -0800
Remove documentation of obsolete B16 & B32 tags in specs/libX11
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit f3c978476e0be6813268af494efb7ac507451116
Author: Matt Turner <mattst88@gmail.com>
Date: Tue Oct 9 10:26:05 2018 -0400
libX11 1.6.7
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit 823a0f8a820247b6c1e092f679b49cbdc2ea5c95
Author: Michel Dänzer <michel.daenzer@amd.com>
Date: Fri Sep 28 17:24:17 2018 +0200