Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the trie class threadsafe? #13

Open
sbyma opened this issue Jul 9, 2018 · 4 comments
Open

Is the trie class threadsafe? #13

sbyma opened this issue Jul 9, 2018 · 4 comments

Comments

@sbyma
Copy link

sbyma commented Jul 9, 2018

In particular, the main parse_text method. Is it safe for multiple threads to call parse_text at the same time?

@endyul
Copy link

endyul commented Aug 31, 2018

same question +1

@dkurzaj
Copy link

dkurzaj commented Nov 6, 2019

Also interested

@david-pureal
Copy link

I am using the master branch, and i just fix one multi-thread crash bug for my usage.
My usage is very simple: load the dict once and only one thread do the load work. Then multi-thread will call parse_text() and never call insert(). The bug occurs randomly when calling parse_text(), the callstack stops at construct_failure_states(). My solution is make construct_failure_states() a public member function, and call it in load dict thread after loading.

@lougxing
Copy link

construct_failure_states

the function name should be "check_construct_failure_states()"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants