Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.expose fails exposed asserts without errors fails in IE8 #632

Closed
GCheung55 opened this issue Dec 23, 2014 · 1 comment
Closed

.expose fails exposed asserts without errors fails in IE8 #632

GCheung55 opened this issue Dec 23, 2014 · 1 comment
Labels

Comments

@GCheung55
Copy link
Contributor

I see the error in IE8:

[assert.equals] Object doesn't support this property or method expected to be equal to expected spy to have been called at least once but was never called

The error is possibly caused by the assertCalled exposed method executing without scope.

// Throws error "Object doesn't support this property or method"
assertCalled(sinon.spy())

// Throws error "Object doesn't support this property or method"
window.assertCalled(sinon.spy())

// Throws error "expected spy to have been called at least once but was never called"
assertCalled.call(window, sinon.spy())

Would changing the test to execute assertCalled.call(window, sinon.spy()) be acceptable?

@stale
Copy link

stale bot commented Jan 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 13, 2018
@stale stale bot closed this as completed Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant