Fix problem of FakeXMLHttpRequest via $.ajax with async:false #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2014 18:03
related: 4e630b1
cjohansen
added a commit
that referenced
this pull request
Sep 26, 2014
Fix problem of FakeXMLHttpRequest via $.ajax with async:false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for $.Deferred of jsXHR(ex: jqXHR.done()) with async:false
In specification of XHR, xhr fires readystatechange/load event even when synchronous flag is set.
And jQuery.ajax is depending on whether load event is fired from xhr in its callback handling.
So, it might be better that FakeXMLHttpRequest behave as same as when async:true even when async:false, I think.
(related: #510 )