Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore missing type imports from pytest #552

Closed
cjolowicz opened this issue Sep 24, 2020 · 1 comment · Fixed by #590
Closed

Do not ignore missing type imports from pytest #552

cjolowicz opened this issue Sep 24, 2020 · 1 comment · Fixed by #590
Labels
bug Something isn't working
Milestone
2020.10.15

Comments

@cjolowicz
Copy link
Owner

pytest comes with types now. Remove these sections from mypy.ini:

[mypy-pytest]
ignore_missing_imports = True

[mypy-tests.*]
disallow_untyped_decorators = False
@cjolowicz cjolowicz added this to the 2020.10.15 milestone Sep 24, 2020
@cjolowicz cjolowicz added the bug Something isn't working label Sep 24, 2020
@cjolowicz
Copy link
Owner Author

Labelling this as a bug because mypy should generate an error if ignore_missing_imports is applied without reason.

@cjolowicz cjolowicz mentioned this issue Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2020.10.15
Development

Successfully merging a pull request may close this issue.

Do not ignore missing type imports from pytest cjolowicz/cookiecutter-hypermodern-python
1 participant
@cjolowicz