Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting from clipboard makes two duplicates rather than one #24

Closed
pihart opened this issue Oct 9, 2020 · 10 comments
Closed

Pasting from clipboard makes two duplicates rather than one #24

pihart opened this issue Oct 9, 2020 · 10 comments
Labels
won't fix This will not be worked on

Comments

@pihart
Copy link
Collaborator

pihart commented Oct 9, 2020

After fixing #23
@pihart
Copy link
Collaborator Author

pihart commented Oct 9, 2020

Issue happens when object is in both qboard and device clipboard

@pihart
Copy link
Collaborator Author

pihart commented Oct 9, 2020

Additionally, both qboard and device clipboard are pasted from. Reproduce: copy an external image and paste into qboard. Now copy the pasted one and paste it again. You have 3 images on the screen

@cjquines cjquines added the bug Something isn't working, and it affects the end user label Oct 9, 2020
@cjquines
Copy link
Owner

cjquines commented Oct 9, 2020

cannot reproduce; can you provide more specific instructions?

@pihart
Copy link
Collaborator Author

pihart commented Oct 10, 2020

Are you testing on the latest version? I have it hosted here: https://pihart.github.io/qboard/

@pihart
Copy link
Collaborator Author

pihart commented Oct 10, 2020

(Make sure to drag away one of the pasted objects because they both get added in the same location)

@cjquines
Copy link
Owner

couldn't repro there either. is your ctrl+v shortcut linked to paste? because if so then this is intended behavior

@pihart
Copy link
Collaborator Author

pihart commented Oct 10, 2020

It is. Why is this intended?

@cjquines
Copy link
Owner

the clipboard api sucks. when we call the paste action we have no way of knowing if the system paste action is also happening at the same time without a heavy refactor? the default keybindings have been changed so that ctrl+v is no longer bound to paste so idk

@cjquines cjquines added won't fix This will not be worked on and removed bug Something isn't working, and it affects the end user labels Oct 10, 2020
@pihart pihart closed this as completed Oct 10, 2020
@pihart pihart reopened this Oct 10, 2020
@pihart
Copy link
Collaborator Author

pihart commented Oct 10, 2020

Can this not be tested here: 5932e27#diff-b3afd2997c4961162817af5a45adc69cR167 ?

@cjquines
Copy link
Owner

still exists actually; closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
won't fix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjquines @pihart