Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force a new webpack build in production #1

Open
Dan1one opened this issue Aug 6, 2018 · 1 comment
Open

Force a new webpack build in production #1

Dan1one opened this issue Aug 6, 2018 · 1 comment

Comments

@Dan1one
Copy link

Dan1one commented Aug 6, 2018

It seems to me, this project doesn't rebuild the app.js file on production.

It executes the one you have last built during development. I also noticed you had also included the phoenix-static buildpack configuration but whenever I include that buildpack, the deployment process fails: due to the fact it tries to execute brunch. Which of course has been removed.

Am I missing something here? Any pointers as to how to force the build process to trigger another rebuild at the time of deployment. More importantly a build for production (optimised, minified, etc)

Edit: Forgot to say thanks for your article and repo, and thanks in advance for your help. Cheers.

@ck3g
Copy link
Owner

ck3g commented Aug 7, 2018

Hey @Dan1one

I've just cloned the repo and introduced new changes in the React component. You can also check them on production. The JS and CSS files have been updated and minimized.

It seems to me that you might miss some step of configuration.

Could you create a new phoenix app and apply all the steps from the article? Will you face the same issues? Or maybe you can walk through the changes in your application and check if you remove "brunch" correctly and your Webpack config looks similar to the one from that repo.

Here you can read how I've configured deploy to Heroku and "compile" section from the Heroku buildpack phoenix static readme.

Let me know if you have figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants