/
test_delete.py
236 lines (201 loc) · 8.44 KB
/
test_delete.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
import json
import nose
import pylons
import sqlalchemy
import sqlalchemy.orm as orm
import ckan.plugins as p
import ckan.lib.create_test_data as ctd
import ckan.model as model
import ckan.tests.legacy as tests
import ckanext.datastore.db as db
from ckanext.datastore.tests.helpers import rebuild_all_dbs, set_url_type
class TestDatastoreDelete(tests.WsgiAppCase):
sysadmin_user = None
normal_user = None
Session = None
@classmethod
def setup_class(cls):
if not tests.is_datastore_supported():
raise nose.SkipTest("Datastore not supported")
p.load('datastore')
ctd.CreateTestData.create()
cls.sysadmin_user = model.User.get('testsysadmin')
cls.normal_user = model.User.get('annafan')
resource = model.Package.get('annakarenina').resources[0]
cls.data = {
'resource_id': resource.id,
'aliases': u'b\xfck2',
'fields': [{'id': 'book', 'type': 'text'},
{'id': 'author', 'type': 'text'},
{'id': 'rating with %', 'type': 'text'}],
'records': [{'book': 'annakarenina', 'author': 'tolstoy',
'rating with %': '90%'},
{'book': 'warandpeace', 'author': 'tolstoy',
'rating with %': '42%'}]
}
engine = db.get_write_engine()
cls.Session = orm.scoped_session(orm.sessionmaker(bind=engine))
set_url_type(
model.Package.get('annakarenina').resources, cls.sysadmin_user)
@classmethod
def teardown_class(cls):
rebuild_all_dbs(cls.Session)
p.unload('datastore')
def _create(self):
postparams = '%s=1' % json.dumps(self.data)
auth = {'Authorization': str(self.sysadmin_user.apikey)}
res = self.app.post('/api/action/datastore_create', params=postparams,
extra_environ=auth)
res_dict = json.loads(res.body)
assert res_dict['success'] is True
return res_dict
def _delete(self):
data = {'resource_id': self.data['resource_id']}
postparams = '%s=1' % json.dumps(data)
auth = {'Authorization': str(self.sysadmin_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth)
res_dict = json.loads(res.body)
assert res_dict['success'] is True
assert res_dict['result'] == data
return res_dict
def test_delete_basic(self):
self._create()
self._delete()
resource_id = self.data['resource_id']
c = self.Session.connection()
# It's dangerous to build queries as someone could inject sql.
# It's okay here as it is a test but don't use it anyhwere else!
results = c.execute(
u"select 1 from pg_views where viewname = '{0}'".format(
self.data['aliases']
)
)
assert results.rowcount == 0
try:
# check that data was actually deleted: this should raise a
# ProgrammingError as the table should not exist any more
c.execute(u'select * from "{0}";'.format(resource_id))
raise Exception("Data not deleted")
except sqlalchemy.exc.ProgrammingError as e:
expected_msg = 'relation "{0}" does not exist'.format(resource_id)
assert expected_msg in str(e)
self.Session.remove()
def test_delete_invalid_resource_id(self):
postparams = '%s=1' % json.dumps({'resource_id': 'bad'})
auth = {'Authorization': str(self.sysadmin_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth, status=404)
res_dict = json.loads(res.body)
assert res_dict['success'] is False
def test_delete_filters(self):
self._create()
resource_id = self.data['resource_id']
# try and delete just the 'warandpeace' row
data = {'resource_id': resource_id,
'filters': {'book': 'warandpeace'}}
postparams = '%s=1' % json.dumps(data)
auth = {'Authorization': str(self.sysadmin_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth)
res_dict = json.loads(res.body)
assert res_dict['success'] is True
c = self.Session.connection()
result = c.execute(u'select * from "{0}";'.format(resource_id))
results = [r for r in result]
assert len(results) == 1
assert results[0].book == 'annakarenina'
self.Session.remove()
# shouldn't delete anything
data = {'resource_id': resource_id,
'filters': {'book': 'annakarenina', 'author': 'bad'}}
postparams = '%s=1' % json.dumps(data)
auth = {'Authorization': str(self.sysadmin_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth)
res_dict = json.loads(res.body)
assert res_dict['success'] is True
c = self.Session.connection()
result = c.execute(u'select * from "{0}";'.format(resource_id))
results = [r for r in result]
assert len(results) == 1
assert results[0].book == 'annakarenina'
self.Session.remove()
# delete the 'annakarenina' row and also only use id
data = {'id': resource_id,
'filters': {'book': 'annakarenina', 'author': 'tolstoy'}}
postparams = '%s=1' % json.dumps(data)
auth = {'Authorization': str(self.sysadmin_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth)
res_dict = json.loads(res.body)
assert res_dict['success'] is True
c = self.Session.connection()
result = c.execute(u'select * from "{0}";'.format(resource_id))
results = [r for r in result]
assert len(results) == 0
self.Session.remove()
self._delete()
def test_delete_is_unsuccessful_when_called_with_invalid_filters(self):
self._create()
data = {
'resource_id': self.data['resource_id'],
'filters': {
'invalid-column-name': 'value'
}
}
postparams = '%s=1' % json.dumps(data)
auth = {'Authorization': str(self.normal_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth, status=409)
res_dict = json.loads(res.body)
assert res_dict['success'] is False
assert res_dict['error'].get('filters') is not None, res_dict['error']
self._delete()
def test_delete_is_unsuccessful_when_called_with_filters_not_as_dict(self):
self._create()
data = {
'resource_id': self.data['resource_id'],
'filters': []
}
postparams = '%s=1' % json.dumps(data)
auth = {'Authorization': str(self.normal_user.apikey)}
res = self.app.post('/api/action/datastore_delete', params=postparams,
extra_environ=auth, status=409)
res_dict = json.loads(res.body)
assert res_dict['success'] is False
assert res_dict['error'].get('filters') is not None, res_dict['error']
self._delete()
def test_delete_with_blank_filters(self):
self._create()
res = self.app.post(
'/api/action/datastore_delete',
params='{0}=1'.format(
json.dumps({
'resource_id': self.data['resource_id'],
'filters': {}
})
),
extra_environ={
'Authorization': str(self.normal_user.apikey)
},
status=200
)
results = json.loads(res.body)
assert(results['success'] is True)
res = self.app.post(
'/api/action/datastore_search',
params='{0}=1'.format(
json.dumps({
'resource_id': self.data['resource_id'],
})
),
extra_environ={
'Authorization': str(self.normal_user.apikey)
},
status=200
)
results = json.loads(res.body)
assert(results['success'] is True)
assert(len(results['result']['records']) == 0)
self._delete()