New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity Stream from: Organization Error group not found #1519
Conversation
I actually checked again and also on demo.ckan.org, filtering the activity stream for an organization that I am following doesn't work. |
The old implementation had the same type for orgs and groups and when an org was selected a 404 was returned because group_show was called. I didn't go all the way down separating both, ie group_followee list still returns both groups and orgs.
Thank you! Now it works like a charm! |
:rtype: int | ||
|
||
''' | ||
return group_follower_count(context, data_dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely happy with group_follower_count
and organization_follower_count
revealing the follower count for both. Is it worth making sure you can't call group_follower_count
for orgs and vice versa? We seem to have done that for major organization_
and group_
functions. If it's not worth the trouble, I'm happy to leave as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way this was implemented at the model level does not differentiate at all between groups and orgs. See _follower_count
and the ModelClass
parameter. I added organization_follower_count
in case we want to refactor it at some point, but I don't think it is necessary now.
Cheers. |
Activity Stream from: Organization Error group not found
The old implementation had the same type for orgs and groups and when an org was selected a 404 was returned because group_show was called. I didn't go all the way down separating both, ie group_followee list still returns both groups and orgs. Conflicts: ckan/logic/action/get.py
Hi, I am running CKAN 2.3a, it seems there is a bug also present in master.ckan.org concerning organization filtering.
After I follow an organization and I try from the dashboard to filter the activity stream to see only the activity stream of that organization, I get an error:
404 Not Found
The resource could not be found.
group not found
It seems a bug, but in the demo instance http://demo.ckan.org/ everything works fine.
Could you please check?
Thank you.