Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Stream from: Organization Error group not found #1519

Merged
merged 3 commits into from Apr 10, 2014

Conversation

amercader
Copy link
Member

Hi, I am running CKAN 2.3a, it seems there is a bug also present in master.ckan.org concerning organization filtering.
After I follow an organization and I try from the dashboard to filter the activity stream to see only the activity stream of that organization, I get an error:

404 Not Found
The resource could not be found.
group not found

It seems a bug, but in the demo instance http://demo.ckan.org/ everything works fine.

Could you please check?

Thank you.

  • Fabrizio

@ghost
Copy link
Author

ghost commented Feb 25, 2014

I actually checked again and also on demo.ckan.org, filtering the activity stream for an organization that I am following doesn't work.

The old implementation had the same type for orgs and groups and when an
org was selected a 404 was returned because group_show was called.

I didn't go all the way down separating both, ie group_followee list
still returns both groups and orgs.
@nigelbabu nigelbabu assigned nigelbabu and unassigned amercader Mar 4, 2014
@ghost
Copy link
Author

ghost commented Mar 6, 2014

Thank you! Now it works like a charm!

@ghost ghost closed this Mar 6, 2014
@nigelbabu nigelbabu reopened this Mar 7, 2014
:rtype: int

'''
return group_follower_count(context, data_dict)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely happy with group_follower_count and organization_follower_count revealing the follower count for both. Is it worth making sure you can't call group_follower_count for orgs and vice versa? We seem to have done that for major organization_ and group_ functions. If it's not worth the trouble, I'm happy to leave as such.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this was implemented at the model level does not differentiate at all between groups and orgs. See _follower_count and the ModelClass parameter. I added organization_follower_count in case we want to refactor it at some point, but I don't think it is necessary now.

@amercader amercader assigned amercader and unassigned nigelbabu Mar 13, 2014
@nigelbabu
Copy link
Contributor

Cheers.

nigelbabu added a commit that referenced this pull request Apr 10, 2014
Activity Stream from: Organization Error group not found
@nigelbabu nigelbabu merged commit 1c86590 into master Apr 10, 2014
@nigelbabu nigelbabu deleted the 1519-fix-orgs-in-dashboard branch April 10, 2014 04:58
amercader added a commit that referenced this pull request Jun 19, 2014
The old implementation had the same type for orgs and groups and when an
org was selected a 404 was returned because group_show was called.

I didn't go all the way down separating both, ie group_followee list
still returns both groups and orgs.

Conflicts:
	ckan/logic/action/get.py
amercader added a commit that referenced this pull request Jun 19, 2014
amercader added a commit that referenced this pull request Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants