Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clean_action_name #1625

Closed
rossjones opened this issue Apr 2, 2014 · 3 comments · Fixed by #1654
Closed

Remove clean_action_name #1625

rossjones opened this issue Apr 2, 2014 · 3 comments · Fixed by #1654

Comments

@rossjones
Copy link
Contributor

clean_action_name ( https://github.com/ckan/ckan/blob/master/ckan/new_authz.py#L109-L113 ) is only called on IAuthFunctions implementations and renames them replacing 'package' with 'dataset'. This can end up with a user implementing an auth function test_package() which then if called with check_access('test_package') will fail because test_dataset could not be found.

This is horrible, it should be removed and documentation used to suggest people use the new naming scheme if it is important.

@wardi
Copy link
Contributor

wardi commented Apr 2, 2014

+1

@seanh
Copy link
Contributor

seanh commented Apr 3, 2014

Good idea

@davidread
Copy link
Contributor

Do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants