Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group read includes datasets even though the comment claims otherwise #1892

Closed
Zharktas opened this issue Aug 20, 2014 · 2 comments
Closed
Assignees

Comments

@Zharktas
Copy link
Member

https://github.com/ckan/ckan/blob/master/ckan/controllers/group.py#L186

The code enters include_datasets as false to context but group_show action gets it from data_dict

https://github.com/ckan/ckan/blob/master/ckan/logic/action/get.py#L1116

This results in duplicate inclusion of datasets and validations which slows down group_show when the group has a lot of extra fields.

@wardi
Copy link
Contributor

wardi commented Aug 21, 2014

@Zharktas good catch. I'll merge your fix at 7ad11f0 if you submit a pull request.

@Zharktas
Copy link
Member Author

pull request in #1895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants