Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add num_followers to ckan.logic.action.get.package_show #2374

Closed
u10313335 opened this issue Apr 2, 2015 · 4 comments
Closed

Add num_followers to ckan.logic.action.get.package_show #2374

u10313335 opened this issue Apr 2, 2015 · 4 comments
Assignees

Comments

@u10313335
Copy link
Contributor

Should we add num_followers to ckan.logic.action.get.package_show to prevent from using deprecated h.get_action() in ckan/templates/package/snippets/info.html? I will send a pull request later.

@wardi
Copy link
Contributor

wardi commented Apr 2, 2015

see #2375 (comment)

@wardi wardi closed this as completed Apr 2, 2015
@u10313335
Copy link
Contributor Author

Just wondering if it is okay to change:
h.SI_number_span(h.get_action('dataset_follower_count', {'id': pkg.id})) }} in ckan/templates/package/snippets/info.html
to something like
h.SI_number_span(h.follow_count('dataset', pkg.id)) to get the number of followers of a dataset (the h.follow_count is a built-in helper function).

@wardi
Copy link
Contributor

wardi commented Apr 3, 2015

@u10313335 sounds perfect

@u10313335
Copy link
Contributor Author

Thanks @wardi, I will create a new issue and work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants