-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wordwrap/break of Organisation Titles #2754
Comments
|
@TkTech yep, I also just realized that here are screenshots that display before and after behavior with a group called Before the changeAfter the changeIt would probably be best if we could limit this to only break words that are much too long. Or use automatic hyphenation which unfortunately only has medium support: http://caniuse.com/#feat=css-hyphens |
Support for word breaks have historically been slowly and painful implemented. The only "portable" way I know of at the moment is to use a css rule to always break-on-character and use a bit of javascript to fix it live, which can cause redrawing and a visually jarring user experience when the page loads. Boundary analysis is a real pain when working with multiple languages. |
burn all the grids! |
We could for example include the hyphenator polyfill to make this work on browsers that do not support |
https://github.com/mnater/Hyphenator/blob/wiki/en_AddNewLanguage.md#what-we-have-now It seems it has considerable multilanguage support, thus I'm in favour of it. 134kb of static content is irrelevant compared to the weight of existing uncached pages. |
or we could use a list instead of a grid and just show the whole group name in a nice easy-to-scan way. Less space wasted on group images too. |
We decided to close old issues that are not actively worked on so that we can focus our effort and attention on issues affecting the current versions of CKAN. If this issue is still affecting the version of CKAN you're working with now, please feel free to comment or reopen the issue. If you do reopen this issue, please update it with new details. One reason it might not have been resolved in the past is that it wasn't clear how a contributor could address the issue. |
After upgrading we have found that on the Organisations page (e.g. https://datastore.landcareresearch.co.nz/organization) the headings of the organisations are not breaking correctly at word breaks, but rather cutting words into bits e.g. below. We have discovered that this is browser influenced – it displays correctly in Chrome, as below (Fig1) in Firefox, and partly OK in IE (the word breaks are correct, but it only displays 2 columns (Fig2).
![fig1 firefox](https://cloud.githubusercontent.com/assets/4842751/11353299/c823bfde-92a6-11e5-9d71-80ab84c965d9.png)
![fig2 ie](https://cloud.githubusercontent.com/assets/4842751/11353304/d4d3ad3e-92a6-11e5-88bd-99f40078b194.png)
Firefox:
IE:
The word break issue also occurs elsewhere Organisation names are displayed e.g. https://datastore.landcareresearch.co.nz/dataset/nzflora-fife-2014-anomodontaceae, not just the Organisation Page(s).
This issue has developed in the update path from CKAN 2.2.1 to 2.3, and continued into 2.4.1.
This problem is also evident on demo.ckan.org http://demo.ckan.org/organization?sort=&q=&page=2 (and e.g. http://demo.ckan.org/organization/department-of-agriculture).
![fig4 ie - ckan demo](https://cloud.githubusercontent.com/assets/4842751/11353474/4328cf98-92a8-11e5-9dea-66d16c8f4edf.png)
Behaviour is not consistent e.g In IE this organisation displays OK on the Organisation page . http://demo.ckan.org/organization?sort=&q=&page=2
But, click into the organisation and the words break incorrectly (http://demo.ckan.org/organization/consumer-financial-protection-bureau).
In Firefox I get the split P rotection in both ‘views’. In Chrome is fine.
The text was updated successfully, but these errors were encountered: