-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CKAN 2.6.0 tests fail #3372
Comments
|
Is 2.6.0 running under test at CircleCI? If so, is there a URL for the test output? |
@rwillmer it is, here are the latest tests along the 2.6 branch https://circleci.com/gh/ckan/ckan/tree/dev-v2.6 You can see the release here: https://circleci.com/gh/ckan/ckan/1953 |
@rwillmer do you have the right versions of all the python dependencies installed? in particular I noticed this error:
|
@rwillmer Wrap your blocks in triple-tildes to format it correctly, I've gone ahead and edited your comment :) |
thanks. I believe I've built against the 2.6.0 branch; I'll debug my version against the CircleCI version. |
Interesting about the pylons version comment; I'm using the requirements file for the dependencies so this should be correct. I'll figure out where that's getting updated. |
If I understand your original post correctly then it seems that you are running
with
|
The virtualenv documentation states that you don't need to use activate. From https://virtualenv.pypa.io/en/stable/userguide/#usage,
|
I think the problems I'm having are to do with software versions and locales. (that failing pylons version test was a red herring) I'm rather hampered by the fact that the process you're running on CircleCI doesn't match the 2.6.0 documentation. For example, if you follow the documentation for installing from source and then testing, on ubuntu:trusty, you'd be using Postgres 9.3, and the standard packaged Solr-Jetty. Whereas from looking at the output from the successful run on CircleCI, then we're using an unknown version of Postgres and the very old Solr 4.3.1 (from June 2013) and running it directly. I'm definitely having an install problem with taking a standard trusty install, it's using the POSIX locale by default. Which means that the createdb commands fail, until I delete the automatically installed pgcluster, and recreate using a UTF locale. And quite a few of the errors I'm seeing are Unicode and pattern matching related, AFAICS. My questions about the CircleCI install are: If that doesn't exist in the 2.6.0 release, does it exist in any more recent dev version? Thanks for any pointers; I'm trying to write an automatic build/test/install process, so may be able to contribute some useful scripts if I can get this to work. |
@rwillmer You don't need to activate the virtualenv if you want to execute a single command. That's why your execution of Regarding your locale problems, CKAN's installation docs tell you to make sure that your PostgreSQL instance is configured to use UTF-8:
|
Thanks, @torfsen. That's news to me that those two forms wouldn't always produce identical results! I'd always assumed that the wording on the virtualenv site meant the two forms could be used interchangeably; I learn something every day. Ok, so I've built it all again from scratch using activate everywhere. Now using the solr config from the CircleCI setup. Now it's down to 3 errors, but it is still failing. I'll post the errors in a following comment, but they are unicode/locale related. I have some questions: 1/ It would be useful to know what version of postgres is used, and what locale is used. 2/ In the CircleCI setup, you are calling ./bin/solr_init/create_core.sh, which doesn't appear in the installation/testing documentation. Is that something that needs to be called in a standard install? Or is there some other part of the procedure which replicates what that does? 3/ The ckan.ini that is generated by paster make_config has several plugins:
(to which I add "datastore") whereas the test_core.ini only has "stats". Does that mean that the other plugins aren't being tested? Should my test_core.ini include all the plugins I use in production? |
|
It's a locale problem, as I thought. The docker ubuntu image I'm using has a default charmap of 7-bit ANSI, which doesn't play nicely with 8-bit Norwegian text (as used in the failing test)
This is the problem, so let's fix it
So now we have
And all is well. Just re-rerunning the test-suite to verify, then I'll close this. |
I am getting some of the same failures that @rwillmer was getting. For example:
I am also using Docker to run the tests. I believe I have solved the encoding issues and I think the remaining problems are related to solr. @rwillmer when you say |
The CKAN documentation doesn't match what they are using on CircleCI. I followed the CircleCI link on http://github.com/ckan/ckan and found myself here. https://circleci.com/gh/ckan/ckan So then I found a working test and looked to see how it was setup. |
Thanks a lot for the quick reply @rwillmer. Looks like they are running this script: Is this what you mean when you say the CircleCI build doesn't match the docs? |
The docs at http://docs.ckan.org/en/latest/maintaining/installing/install-from-package.html talk through installing via apt-get from a package and then modifying config files. The CircleCI build gets a solr tarball, and runs it directly as a service without troubling apt-get. Two totally different methods of setting up Solr. |
Ah I see what you mean. Thank you @rwillmer |
CKAN Version if known (or site URL)
2.6.0
Please describe the expected behaviour
I run the nosetests.
The tests all work.
Please describe the actual behaviour
Several tests fail. I will add the failure messages in a comment.
This is the command I use:
What steps can be taken to reproduce the issue?
I can repeat it by rerunning the tests.
The text was updated successfully, but these errors were encountered: