Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Search API #4483

Closed
davidread opened this issue Sep 28, 2018 · 4 comments · Fixed by #4492
Closed

Remove legacy Search API #4483

davidread opened this issue Sep 28, 2018 · 4 comments · Fixed by #4492
Assignees

Comments

@davidread
Copy link
Contributor

davidread commented Sep 28, 2018

CKAN Version if known (or site URL)

Can we officially deprecate the legacy Search API and Utils APIs?

These was described as "legacy API"s since CKAN 2.3 (here)[https://github.com/ckan/ckan/commit/254fca2d43ccacbe674df2da42aba83897dcdb96#diff-b4e5718590c95267775a87dafc922c76). However they have not been marked as deprecated in the changelog.

These are the APIs:

  • /api/search/dataset / /api/search/package (replaced by package_search)
  • /api/search/resource (replaced by resource_search)
  • /api/search/revision (revisions are deprecated)
  • /api/tag_counts (can be done with package_search facet.field='tags')
  • /api/util/dataset/autocomplete (replaced by package_autocomplete)
  • /api/util/tag/autocomplete (replaced by tag_autocomplete)
  • /api/util/resource/format_autocomplete (replaced by format_autocomplete)
  • /api/util/dataset/munge_name
  • /api/util/dataset/munge_title_to_name
  • /api/util/tag/munge

I can't see any replacements for the munge functions and I suspect they are still useful to anyone replacing the CKAN front-end. Should we turn these into action funcs?

(We got rid of the REST API /api/rest/* in 2.8, having been marked as deprecated in the 2.7 changelog)

@amercader
Copy link
Member

That sounds very sensible.

I think that that the munge functions can be easily turned into actions as you suggest, and the rest we should just remove.

@davidread
Copy link
Contributor Author

Nice one @ZoranPandovski !

@howff
Copy link
Contributor

howff commented Nov 11, 2019

scheming is still using tag/autocomplete isn't it?

@davidread
Copy link
Contributor Author

@wardi would know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants