Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds title attribute to iframe #7298

Merged
merged 3 commits into from Jan 5, 2023
Merged

Adds title attribute to iframe #7298

merged 3 commits into from Jan 5, 2023

Conversation

shashigharti
Copy link
Contributor

Fixes #7187

Proposed fixes:

Add title attribute to iframes.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@shashigharti shashigharti changed the title 7187 adds title attribute to iframe Adds title attribute to iframe Dec 31, 2022
@pdelboca pdelboca merged commit 086b32f into ckan:master Jan 5, 2023
@pdelboca
Copy link
Member

pdelboca commented Jan 5, 2023

Thanks @shashigharti !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
zBackport 2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table iframe must have a title attribute
3 participants
@shashigharti @pdelboca @amercader