Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip content visible #7299

Merged
merged 2 commits into from Jan 24, 2023

Conversation

shashigharti
Copy link
Contributor

Fixes #7194

Proposed fixes:

Make skip content visible

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

Made changes to bs5 template
Made changes to bs3 template and scss and css files
Updated translation files
@shashigharti shashigharti changed the title 7194 make skip content visible Make skip content visible Dec 31, 2022
@pdelboca pdelboca merged commit 146e018 into ckan:master Jan 24, 2023
@amercader
Copy link
Member

@pdelboca For the 2.10 backport just replicate the markup changes, not the i18n change from "Skip to content" to "Skip to main content", otherwise it will mess up with the translations update

@pdelboca
Copy link
Member

pdelboca commented Jan 24, 2023

@amercader I did the change at the same moment you were writing the comment. I will undo the backport.

spwoodcock pushed a commit to spwoodcock/ckan that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip to Content not visible for keyboard-only users
4 participants