Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 with ruff #7325

Open
Zharktas opened this issue Jan 12, 2023 · 3 comments
Open

Replace flake8 with ruff #7325

Zharktas opened this issue Jan 12, 2023 · 3 comments

Comments

@Zharktas
Copy link
Member

Many bigger projects are replacing flake8 with ruff, like FastAPI, Jupyter and pandas. This change would have to be made in CI, CI-templates, various extension CIs and so on.

If there is an interest in this, I could do some testing on linting if there are any differences.

@seun-beta
Copy link

Hello @anuveyatsu

I hope you are good. I would like to take up this task as part of my application to Datopian

@seun-beta
Copy link

@Zharktas I completely agree with you. Ruff is around 100x faster than flake8.

This benchmark does justice to it Ruff Benchmark

@smotornyuk
Copy link
Member

Errors present in core(and intentionaly ignored by flakes8 via config) that ruff is not detecting currently: E122, E124, E125, E127, E128, E129, E131, E301, E302, E303, E304, E305, E306, E502, E712

Errors that ruff detects, but flake8 doesn't: E226, E241, E721, E731, F403, F601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants