Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS issue when add member flash an error #8104

Closed
tino097 opened this issue Mar 6, 2024 · 3 comments · Fixed by #8107
Closed

JS issue when add member flash an error #8104

tino097 opened this issue Mar 6, 2024 · 3 comments · Fixed by #8107
Assignees

Comments

@tino097
Copy link
Member

tino097 commented Mar 6, 2024

CKAN version

master / 2.10.x

Describe the bug

The autocomplete component not working if the Add Member have error when debug = false is set in the ini file

Steps to reproduce

debug = false in the ini file
Go to Organization manage page
Navigate to Members
Click on Add member without input
Automplete gets broken

Expected behavior

A clear and concise description of what you expected to happen.
Just to see flash message that user is not slected

Additional details

image

@Zharktas
Copy link
Member

Zharktas commented Mar 7, 2024

@tino097 seems that notify.js is bundled before i18n.js and that is failing in javascript when some notification is shown:

- notify.js
- i18n.js

ckan.i18n hasn't been initialized when it tries to find translation for Close

element.find('.btn-close').attr("aria-label", ckan.i18n._('Close'));

@Zharktas
Copy link
Member

Zharktas commented Mar 7, 2024

Doesn't happen in 2.9 since it doesn't have aria labels for which translations are required.

@tino097
Copy link
Member Author

tino097 commented Mar 7, 2024

Also i've noticed that Datatables is having issues:

  File "/home/tino097/.pyenv/versions/local/lib/python3.10/site-packages/webassets/env.py", line 216, in query_url_mapping
    raise ValueError('Cannot determine url for %s' % filepath)

From @smotornyuk comment we should remove cssrewrite ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants