Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception if resource_proxy not enabled(?) #8

Closed
mattfullerton opened this issue Apr 30, 2015 · 2 comments · Fixed by #19
Closed

Exception if resource_proxy not enabled(?) #8

mattfullerton opened this issue Apr 30, 2015 · 2 comments · Fixed by #19

Comments

@mattfullerton
Copy link

This code:
https://github.com/ckan/ckanext-geoview/blob/master/ckanext/geoview/plugin.py#L149-L157

Is a problem. If we are on the same domain or the proxy is not enabled, proxy_service_url does not get set, even though it is unconditionally needed later

@makkus
Copy link

makkus commented Jun 11, 2015

Is there a workaround for the 'same domain' case? I'm getting 'UnboundLocalError: local variable 'proxy_service_url' referenced before assignment' when trying to create a geoview-view.

@mattfullerton
Copy link
Author

Yes, you can insert "proxy_service_url = None" before "if self.proxy_enabled and not same_domain:" in the file ckanext/geoview/plugin.py

I'll send a pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants