-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API service without business logic #89
Comments
Which directory should the api of a kuai project be placed in? |
How about creating a private demo repo and link dependencies to local kuai project |
Ok, I thought kuai project template included the api, similar to nestjs |
It would be better to provide a template of API service if we could. The template could be added in |
Would you add a backend template or create a new project from scratch temporarily? If one of them will be done by you, I will finish the UI part. |
Ok, I'm adding the api part to the initial project template. I can follow the documentation to mock api input and output first, and then integrate the specific logic after the store part is done. And other qustion, mvp project files should be placed where, a new repository? |
Opening a private repo in https://github.com/Magickbase/ is fine |
How is it going |
The current api server side code is here: https://github.com/Magickbase/kuai-mvp-server need review this peoject structure, if not problem , this structure will integrate to |
create a pull request: https://github.com/Magickbase/kuai-mvp-server/pull/1 |
https://github.com/Magickbase/kuai-mvp-server/pull/1 has been approved by 2 reviewers and was merged into the main branch. Please add it in kuai as the backend template. |
Will be pull request later |
After the Once the
Would you pick one up from tasks? @PainterPuppets @Daryl-L @yanguoyu The tasks not picked will be arranged later(about 18:30 this day). |
I will be doing the |
I think the |
It could be done in either backend or front-end. The main work of If If Either is fine. |
I think there is only |
I'm going to finish |
How is it going? |
PR: #121 |
Please create a project named |
|
Any problem with proposing PRs for review today? |
pr for resource binding to initiate |
The PR for |
Model definition. #126 |
View #127 |
Some logic may have to be complemented in |
|
We may need 2 models for the controller The one that has been added(https://github.com/ckb-js/kuai/blob/develop/packages/samples/mvp-dapp/src/record/record.model.ts) works with a So another model is required to transform a group of The possible workflow would be as follows:
Correct me if it doesn't work or is unnecessary @yanguoyu |
I thought |
|
Do you mean how to init a cell with initialization data? @Keith-CY I think it may init like this: const initModel = new RecordModel()
const { data } = initModel.initOnChain({
data: {
profile: [],
addresses: [],
custom: [],
dweb: [],
}
})
const tx = {
inputs,
outputs,
outputs_data: [data]
} Then broadcast the tx to init a cell |
Get it, except one point we can talk about later. If 2 services are running, without a pattern for |
The above-defined |
Here's my understanding(#85 (comment)), but it was not confirmed or disputed by @Daryl-L From the code(https://github.com/ckb-js/kuai/blob/develop/packages/models/src/resource-binding/manager.ts#L20) we can see that That means, not every cell sent from |
Do you mean I forget to filter cells in |
It should be done in resource-binding, but could be too hurry to finish it for now, filtering in store would be simple in the MVP dapp |
So the resource binding manager should not only filter the cells by type script and lock script, but also parse the data with storage and filter the cells out by pattern, right? |
We haven't discussed it much, so there's no conclusion yet. For me, yes. Resource-binding means providing resources asked by others. Say that, module A declares that it wants A, B, C, to Z, they are all letters, then resource-binding should give letters to module A, but not characters which covers letters and digits. However, in a meeting, we've talked about a compromise that resource-binding could provide a superset of cells to |
This is my understanding of the MVP API process:
I think there are some things we need to implement:
|
The confusion may come from the timing of As the PRD(#54 (comment)) said
Besides, the |
Missing parts:
|
Model and claim method #137 |
PRD: #54
The text was updated successfully, but these errors were encountered: