Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon panel doesn't respect margin of body tag #1048

Closed
wojtekw92 opened this issue Oct 13, 2017 · 0 comments
Closed

Balloon panel doesn't respect margin of body tag #1048

wojtekw92 opened this issue Oct 13, 2017 · 0 comments
Assignees
@msamsel
Labels
plugin:balloonpanel The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.9.0

Comments

@wojtekw92
Copy link
Contributor

wojtekw92 commented Oct 13, 2017 •
edited by mlewand
Loading

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

Balloon panel calculate wrong position coordinates when we add margin to body.

  1. edit balloon panel manual test test (balloonpanel/manual/balloonpanel.html)
  2. remove CSS body styles from html
  3. run test

Expected result

balloon panel position is ok.

Actual result

balloon panel positon is moved for the same length as margin.

Other details

  • Browser: Chrome 62
  • OS: MacOS 10
  • CKEditor version: 4.7.3
  • Installed CKEditor plugins: balloonpanel
@wojtekw92 wojtekw92 added type:bug A bug. status:confirmed An issue confirmed by the development team. labels Oct 16, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 9, 2017
@mlewand mlewand added this to the Backlog milestone Nov 9, 2017
@msamsel msamsel self-assigned this Nov 9, 2017
@msamsel msamsel mentioned this issue Nov 22, 2017
Merged
2 tasks
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. and removed target:major Any docs related issue that should be merged into a major branch. labels Dec 14, 2017
@f1ames f1ames added the plugin:balloonpanel The plugin which probably causes the issue. label Dec 14, 2017
@f1ames f1ames modified the milestones: Backlog, 4.8.1 Dec 14, 2017
@mlewand mlewand mentioned this issue Dec 27, 2017
Closed
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
@msamsel msamsel changed the title Balloon panel body margin handling Balloon panel doesn't respect margin of body tag Feb 8, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Jul 19, 2018
Closed
2 tasks
@Comandeer Comandeer mentioned this issue Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
plugin:balloonpanel The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
4 participants
@f1ames @mlewand @wojtekw92 @msamsel