Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloon panel support attach without showing the toolbar #1118

Closed
wojtekw92 opened this issue Nov 3, 2017 · 0 comments
Closed

Balloon panel support attach without showing the toolbar #1118

wojtekw92 opened this issue Nov 3, 2017 · 0 comments
Assignees
Labels
changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone

Comments

@wojtekw92
Copy link
Contributor

wojtekw92 commented Nov 3, 2017

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

Balloon panel should have option to attach panel without running show function.

We should change attach method to accept options instead of focusElement as a second param.

options object should be like this:

{
    focusElement: CKEDITOR.dom.element/Boolean
    show: Boolean
}
@wojtekw92 wojtekw92 mentioned this issue Nov 3, 2017
2 tasks
@wojtekw92 wojtekw92 self-assigned this Nov 3, 2017
@wojtekw92 wojtekw92 added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Nov 3, 2017
@mlewand mlewand added changelog:api A changelog entry should be put in the API section of the changelog. target:major Any docs related issue that should be merged into a major branch. labels Nov 5, 2017
@mlewand mlewand added this to the 4.8.0 milestone Nov 6, 2017
@mlewand mlewand changed the title Balloon panel support attach without show Balloon panel support attach without showing the toolbar Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

2 participants