Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Toolbar should be re-positioned after a change event #1342

Closed
Comandeer opened this issue Dec 12, 2017 · 0 comments
Closed

Balloon Toolbar should be re-positioned after a change event #1342

Comandeer opened this issue Dec 12, 2017 · 0 comments
Assignees
@Comandeer
Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.9.0

Comments

@Comandeer
Copy link
Member

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Checkout d005e77.
  2. Open http://ckeditor.test/ckeditor-dev/plugins/easyimage/samples/easyimage.html
  3. Click image.
  4. Change image to side one using balloon toolbar.

Expected result

Balloon toolbar changes position to follow image widget.

Actual result

Balloon toolbar stays in the same position, pointing to nowhere…

Other details

  • Browser: …
  • OS: …
  • CKEditor version: 4.8.0
  • Installed CKEditor plugins: balloontoolbar

Note that there is proposed solution in bc37aeb and 7dcba65, which should be a good starting point.
@Comandeer Comandeer added plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Dec 12, 2017
@Comandeer Comandeer self-assigned this Dec 12, 2017
@Comandeer Comandeer mentioned this issue Dec 15, 2017
Merged
2 tasks
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Dec 15, 2017
@mlewand mlewand added this to the Backlog milestone Dec 15, 2017
@mlewand mlewand changed the title Balloon toolbar does not refresh position Balloon toolbar does not refresh position after change event Dec 19, 2017
@mlewand mlewand changed the title Balloon toolbar does not refresh position after change event Balloon Toolbar should be re-positioned after a change event Dec 19, 2017
@mlewand mlewand modified the milestones: Backlog, 4.8.1 Dec 19, 2017
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
2 participants
@Comandeer @mlewand