Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Toolbar API should be available in plugin.init() #1346

Closed
mlewand opened this issue Dec 13, 2017 · 2 comments
Closed

Balloon Toolbar API should be available in plugin.init() #1346

mlewand opened this issue Dec 13, 2017 · 2 comments
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:feature A feature request.
Milestone
4.9.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Dec 13, 2017

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

While making a PoC plugin, reusing Balloon Toolbar, I was surprised that the API is not exposed in plugin.init(), thus I had to use afterInit() which is not an elegant workaround.

It's the result of #1142 in a long run, but maybe we could fix it without waiting for #1142 fix? For instance init Balloon Toolbar APIs in beforeInit().

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.8.0
@mlewand mlewand added changelog:api A changelog entry should be put in the API section of the changelog. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:feature A feature request. labels Dec 13, 2017
@mlewand mlewand added this to the Backlog milestone Dec 29, 2017
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Dec 29, 2017
@jacekbogdanski jacekbogdanski mentioned this issue Jan 8, 2018
Merged
2 tasks
@f1ames f1ames modified the milestones: Backlog, 4.8.1 Jan 11, 2018
This was referenced Jan 11, 2018
Closed
Open
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
@lmcsu
Copy link

lmcsu commented Mar 24, 2020

Seems like it doesn't work.
"this.build()" is called in balloonpanel before "build" is initialized in balloontoolbar's "init".
So it throws an error like there's no such function.

@dimitrov-adrian
Copy link

Able to reproduce quite often when throttling connection to Fast/Slow 3G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:feature A feature request.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
4 participants
@dimitrov-adrian @f1ames @mlewand @lmcsu