Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon toolbar should destroy its content properly #1477

Closed
engineering-this opened this issue Jan 19, 2018 · 1 comment · Fixed by #1482
Closed

Balloon toolbar should destroy its content properly #1477

engineering-this opened this issue Jan 19, 2018 · 1 comment · Fixed by #1482
Assignees
@engineering-this
Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.11.0

Comments

@engineering-this
Copy link
Contributor

engineering-this commented Jan 19, 2018 •
edited by mlewand
Loading

Are you reporting a feature request or a bug?

Bug

Description

When calling destroy on balloonToolbar it doesn't invoke destroy on its children elements (_items).

Current situation might cause some issues with eg. richCombo which itself doesn't have such method.

We should add new method destroy to richCombo, and call it within balloonToolbar destroy.
@engineering-this engineering-this added type:task Any other issue (refactoring, typo fix, etc). target:major Any docs related issue that should be merged into a major branch. plugin:balloontoolbar The plugin which probably causes the issue. labels Jan 19, 2018
@engineering-this engineering-this self-assigned this Jan 19, 2018
@engineering-this engineering-this changed the title Balloon toolbar on destroy should also destroy its items. Balloon toolbar on destroy should also destroy its content Jan 19, 2018
@engineering-this engineering-this mentioned this issue Jan 22, 2018
Merged
2 tasks
@mlewand mlewand changed the title Balloon toolbar on destroy should also destroy its content Balloon toolbar should destroy its content properly Jan 22, 2018
@mlewand mlewand added the status:confirmed An issue confirmed by the development team. label Jan 22, 2018
@mlewand mlewand added this to the Backlog milestone Jan 22, 2018
@mlewand mlewand added type:bug A bug. and removed type:task Any other issue (refactoring, typo fix, etc). labels Jan 22, 2018
@engineering-this engineering-this removed their assignment Jan 30, 2018
@engineering-this engineering-this self-assigned this Aug 31, 2018
@mlewand mlewand modified the milestones: Backlog, 4.11.0 Sep 15, 2018
@Comandeer
Copy link
Member

Fixed in #1482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Balloon toolbar on destroy doesn't destroy its content ckeditor/ckeditor4
3 participants
@Comandeer @mlewand @engineering-this