CKFinder Quickupload integration got broken due to latest changes in CKEditor 4.9.0

[jswiderski]

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

1. Download CKFinder 3.4.2 for PHP or ASP.NET and install it on a server
2. Open ckfinder/samples/ckeditor.html and change editor version from 4.5.10 to 4.9.0
3. Upload a file through upload tab

Expected result

The request should look more or less like below and upload should finish with success:
http://test.dev/ckfinder-aspnet-342/connector?command=QuickUpload&type=Files&CKEditor=editor1&CKEditorFuncNum=0&langCode=pl

Actual result

The request looks like below and CKFinder returns 109 Invalid Request error what results in HTTP 400 being returned:
http://test.dev/ckfinder-aspnet-342/connector?command=QuickUpload&type=Files

Other details

• Browser: Any
• OS: Any
• CKEditor version: 4.9.0
• Installed CKEditor plugins: filebrowser

CKEditor 4.9.0

CKEditor 4.8.0

[AnnaTomanek]

Can confirm, something's wrong, can be reproduced on the SDK samples as well. When trying to upload files through the Upload tab, an error is returned.

The console:

Drag&drop upload seems to be working OK and it's also possible to add images previously uploaded to CKFinder.

[Comandeer]

It seems that the issue is connected with configuration. Setting config to:

config.filebrowserBrowseUrl = '/ckfinder/ckfinder.html';
config.filebrowserUploadUrl = '/ckfinder/core/connector/php/connector.php?command=QuickUpload&type=Files&responseType=json';

or to

config.filebrowserBrowseUrl = '/ckfinder/ckfinder.html';
config.filebrowserUploadMethod = 'form';
config.filebrowserUploadUrl = '/ckfinder/core/connector/php/connector.php?command=QuickUpload&type=Files';

fixes the issue.

What's more, even when CKEditor shows "Incorrect server response", the upload is done. The only issue is with reading the server's answer due to incorrect format (CKFinder responds with JS code by default and XHR uploader is waiting for JSON).

[wwalc]

Unfortunately, it looks like the only reasonable (from the end user point of view) solution will be quite ugly:

1. In CKEditor, if the upload method is xhr check the destination URL for upload (I intentionally did not use the exact configuration option name as there are plenty of ways to set it).
2. If the URL (query string) contains command=QuickUpload and does not contain responseType=json then append &responseType=json to it.

This way all URLs that point to CKFinder will be correctly adjusted. There is no other reasonable way to fix the issue.

Note: searching for command=QuickUpload is a good enough check to understand if it's a URL to CKFinder uploader. Do not try searching for "connector", "ckfinder" etc. as this part of the URL is configurable and completely virtual e.g. in case of Java. Even if some third party code is using same parameter/value (command=QuickUpload) chances that appending &responseType=json will break something are close to zero.

[mlewand]

Fixed by #1840.

[jonnott]

Am I right in thinking this only fixes CKFinder v3.x, and not CKFinder v2.x ?
Doesn't seem to make a different to v2.4 or v2.4.2 - same error 'Incorrect server response' occurs.
Guess there's no responseType query string param in v2.x ?

[jonnott]

As integration with CKFinder v2.x worked perfectly fine until CKEditor v4.9.x, I'd consider this to be a BC break/regression still, and therefore this merge not a satisfactory resolution, unless there has been a point previously where CKEditor's support for CKFinder v2.x has been officially dropped in a major version release...?

[jonnott]

@mlewand motioning to re-open the issue ;)

[mlewand]

@jonnott it should be tracked in a separate issue, thanks for creating #1869.