Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to add new list items under an item containing block element #2205

Closed
jswiderski opened this issue Jul 5, 2018 · 2 comments
Assignees
Labels
status:confirmed An issue confirmed by the development team. support:3 An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open editor sample and clean editor contents - https://sdk.ckeditor.com/samples/fullpreset.html.
  2. Insert list.
  3. Type text in first list item e.g. "test" and press Enter.
  4. Insert table in second list item, move below the table using arrows and press Enter.

Please see attached video to get a visual representation of what I’m describing.
table.zip

Expected result

Third list item gets created.

Actual result

Second item together with table is being removed.

Other details

Problem with removing list item together with a table can be reproduced from CKEditor 4.4.3 however first problems started occurring in version 4.3.0 where it was no longer possible to create new list item but instead new lines were added to second item of the list.

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.4.3+
  • Installed CKEditor plugins: table
@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. labels Jul 5, 2018
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Jul 6, 2018
@jacekbogdanski jacekbogdanski self-assigned this Oct 16, 2018
@jacekbogdanski
Copy link
Member

This issue applies to any block element e.g. tables, forms etc. It's caused by enterkey plugin which incorrectly handles opening new line for block elements: https://github.com/ckeditor/ckeditor-dev/blob/major/core/editable.js#L395-L398

@jacekbogdanski jacekbogdanski changed the title It is not possible to add new list items under an item containing table It is not possible to add new list items under an item containing block element Oct 22, 2018
@lslowikowska lslowikowska added support:1 An issue reported by a commercially licensed client. and removed support An issue reported by a commercially licensed client. labels Dec 14, 2018
@Comandeer Comandeer added this to the 4.11.2 milestone Jan 2, 2019
@Comandeer
Copy link
Member

Fix was merged into 4.11.2 release.

@lslowikowska lslowikowska added support:3 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. support:3 An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants