Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting content from MS Outlook and then bolding it results in JS error #2294

Closed
jswiderski opened this issue Aug 8, 2018 · 3 comments
Closed

Pasting content from MS Outlook and then bolding it results in JS error #2294

jswiderski opened this issue Aug 8, 2018 · 3 comments
Assignees
@mlewand
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@jswiderski
Copy link
Contributor

jswiderski commented Aug 8, 2018 •
edited by mlewand
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://codepen.io/mlewand/pen/gdWWJO.
  2. Copy contents from attached MS Outlook message - using Ctrl+A Ctrl+C shortcuts.
  3. Open editor sample in a browser, click inside the editor, press Ctrl+A and then Backspace or Delete.
  4. Paste Outlook contents using Ctrl+V
  5. Don't click anywhere (this is especially important when reproducing in Chrome) and just press Ctrl+A
  6. Ctrl+A to select all the content and then click on Bold button in the toolbar.

Screen Cast: error.zip
Outlook Message: Sample Mail.zip

Expected result

Content gets Bold, no error are thrown in the console.

Actual result

Content gets Bold however js error is thrown:
Message: Cannot read property 'getParents' of null
File: range.js
Line: 278
Code: endParents = endNode.getParents(),

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.10.0
@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. browser:chrome The issue can only be reproduced in the Chrome browser. browser:firefox The issue can only be reproduced in the Firefox browser. browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. labels Aug 8, 2018
@mlewand mlewand self-assigned this Aug 24, 2018
@mlewand mlewand changed the title Pasting content from MS Outlook and then bolding it results in JS error Color button throws an error when activated on a content containing HTML comments Aug 24, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. plugin:colorbutton The plugin which probably causes the issue. and removed browser:chrome The issue can only be reproduced in the Chrome browser. browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:firefox The issue can only be reproduced in the Firefox browser. labels Aug 24, 2018
@mlewand mlewand mentioned this issue Aug 27, 2018
Merged
2 tasks
@mlewand mlewand changed the title Color button throws an error when activated on a content containing HTML comments Pasting content from MS Outlook and then bolding it results in JS error Aug 27, 2018
@mlewand
Copy link
Contributor

mlewand commented Aug 27, 2018

Reverted original title / description, as I mistakenly have placed updates related to second similar issue (#2296).

@mlewand mlewand assigned mlewand and unassigned mlewand Sep 1, 2018
@mlewand mlewand mentioned this issue Sep 5, 2018
Merged
2 tasks
@Comandeer Comandeer added this to the 4.10.2 milestone Sep 6, 2018
@Comandeer
Copy link
Member

Merged into 4.10.2.

@mlewand
Copy link
Contributor

mlewand commented Sep 6, 2018

Note that this fix has been merged to 4.10.2 release, as 4.10.1 release is already closed and waiting to be released.

You can already preview it on codpen, using 4.10.2 preview: https://codepen.io/mlewand/pen/OoxgqV

@mlewand mlewand modified the milestones: 4.10.2, 4.11.0 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
3 participants
@Comandeer @jswiderski @mlewand