Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ctrl+K keystroke for link command #2478

Closed
Comandeer opened this issue Oct 15, 2018 · 1 comment
Closed

Add Ctrl+K keystroke for link command #2478

Comandeer opened this issue Oct 15, 2018 · 1 comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.11.0

Comments

@Comandeer
Copy link
Member

Comandeer commented Oct 15, 2018 •
edited
Loading

Type of report

Feature request

Provide description of the task

Currently link command is hidden under Ctrl+L keystroke, however the industry standard is Ctrl+K. Probably it'd be better to add the new keystroke for our link plugin to align our behaviour with the rest of the world.
@Comandeer Comandeer added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. plugin:link The plugin which probably causes the issue. labels Oct 15, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. labels Oct 15, 2018
@Comandeer Comandeer added type:feature A feature request. and removed type:task Any other issue (refactoring, typo fix, etc). labels Oct 15, 2018
@Comandeer Comandeer mentioned this issue Oct 15, 2018
Merged
2 tasks
@mlewand mlewand added this to the 4.11.0 milestone Oct 15, 2018
@mlewand mlewand mentioned this issue Oct 18, 2018
Closed
@wimleers
Copy link
Contributor

I'm glad CKEditor is doing this now, back in 2013 we had to add an override for this: https://www.drupal.org/project/drupal/issues/1879120#comment-7556673 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
3 participants
@wimleers @Comandeer @mlewand