Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji dropdown icons are not centered #2572

Closed
engineering-this opened this issue Nov 5, 2018 · 3 comments
Closed

Emoji dropdown icons are not centered #2572

engineering-this opened this issue Nov 5, 2018 · 3 comments
Assignees
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@engineering-this
Copy link
Contributor

engineering-this commented Nov 5, 2018

Type of report

Bug/task

Provide detailed reproduction steps (if any)

  1. Open test:
    /tests/plugins/emoji/manual/dropdown/dropdownfiltering

  2. Open emoji dropdown.

  3. Press left arrow to focus category icons. Inspect each of them.

Actual:

Category icons are not centered, below is how they look when focused. I propose to adjust their positioning so each of them is centered horizontally and vertically. Currently they are aligned top which doesn't look good especially with smaller icons.

screenshot 2018-11-05 at 13 46 16

Second case:

  1. Hover an emoji to show preview.

Actual:

Emoji preview icon is positioned too high and almost touches top border. See below:

screenshot 2018-11-05 at 12 46 48

I propose to add some margin-top to this icon to position it better.

Note: currently there is padding-top on parent element, preview text has additional margin-top:3px. I think same value would be ideal for icon.

Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@engineering-this engineering-this added status:confirmed An issue confirmed by the development team. plugin:emoji The plugin which probably causes the issue. labels Nov 5, 2018
@mlewand mlewand modified the milestones: 4.11.0, 4.11.1 Nov 5, 2018
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. and removed status:confirmed An issue confirmed by the development team. labels Nov 5, 2018
@engineering-this engineering-this changed the title Improve emoji dropdown styling Emoji dropdown: category icons are not centered, preview icon is too high Nov 7, 2018
@mlewand mlewand modified the milestones: 4.11.1, 4.11.2 Nov 7, 2018
@msamsel msamsel self-assigned this Nov 8, 2018
@jacekbogdanski
Copy link
Member

There is also a small issue with gab between emoji panel input border and outline, which could be fixed altogether with this one:

image

It occurs on Chrome.

@msamsel
Copy link
Contributor

msamsel commented Dec 11, 2018

@jacekbogdanski I cannot reproduce this case. I looked on Chrome under Windows and MacOS and this situation doesn't occur for me. Maybe you have set some zoom or made some customisation in browsers, which result with this visual glitch?

@mlewand mlewand modified the milestones: 4.11.2, 4.11.3 Jan 3, 2019
@mlewand mlewand added the type:bug A bug. label Feb 13, 2019
@mlewand mlewand changed the title Emoji dropdown: category icons are not centered, preview icon is too high Emoji dropdown icons are not centered Feb 13, 2019
@mlewand
Copy link
Contributor

mlewand commented Feb 13, 2019

Fixed with #2670.

@mlewand mlewand closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants