Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuButton with label puts "(Selected)" at the end of the label when clicked #421

Closed
mlewand opened this issue May 31, 2017 · 2 comments · Fixed by #2417
Closed

MenuButton with label puts "(Selected)" at the end of the label when clicked #421

mlewand opened this issue May 31, 2017 · 2 comments · Fixed by #2417
Assignees
@jacekbogdanski
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented May 31, 2017

Are you reporting a feature or a bug?

Bug

Check if the issue is already reported

http://dev.ckeditor.com/ticket/14237

Provide detailed reproduction steps (if any)

  1. Add a Menu Button to the toolbar, using the menubutton plugin.
  2. Change the skin css to show the label for the button.
  3. Open the editor and click on the menu button

Expected result

The menu button label should not change.

Actual result

The menu button label changes from 'Label' to 'Label (Selected)'.
@mlewand mlewand added status:confirmed An issue confirmed by the development team. type:bug A bug. labels May 31, 2017
@mlewand mlewand added this to the 4.7.1 milestone May 31, 2017
@mlewand mlewand added the support An issue reported by a commercially licensed client. label May 31, 2017
@mlewand mlewand mentioned this issue Jun 2, 2017
Closed
@mlewand mlewand modified the milestones: 4.7.1, Backlog Jun 20, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Aug 30, 2017
@jacekbogdanski jacekbogdanski self-assigned this Sep 13, 2018
@jacekbogdanski
Copy link
Member

I wonder how this change will affect accessibility? Additional (Selected) postfix is added for TRISTATE_ON state for buttons with arrow indicator i.e colorbutton and menubutton. Do we need indicate by aria label that the button is opened like Language (Selected), Background Color (Selected)?

@mlewand
Copy link
Contributor Author

mlewand commented Sep 13, 2018

@jacekbogdanski aria-expanded attribute should be used to denote opened menu. See https://www.w3.org/TR/wai-aria-practices/examples/menu-button/menu-button-links.html#rps_label.

@jacekbogdanski jacekbogdanski mentioned this issue Sep 14, 2018
Merged
2 tasks
@Comandeer Comandeer modified the milestones: Backlog, 4.11.0 Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Fixed expandable button label when clicked ckeditor/ckeditor4
3 participants
@Comandeer @mlewand @jacekbogdanski