Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEditor Changes Table Style and Border #566

Closed
tomsuchy opened this issue Jun 27, 2017 · 4 comments
Closed

CKEditor Changes Table Style and Border #566

tomsuchy opened this issue Jun 27, 2017 · 4 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@tomsuchy
Copy link

tomsuchy commented Jun 27, 2017

Are you reporting a feature or a bug?

Bug

Check if the issue is already reported

Not Found

Provide detailed reproduction steps (if any)

  1. Go to http://sdk.ckeditor.com/samples/standardpreset.html

  2. Edit <table> tag in "Source" view - edit to resemble the below:

    <table align="right" border="0" cellpadding="5" cellspacing="0" style="border: 0px solid #000000;">

  3. Switch to WYSIWYG view; it has a border.

  4. Switch back to code view: It is now:

    <table align="right" border="1" cellpadding="5" cellspacing="0">

Expected result

It shouldn't put any border, since no border is requested.

Actual result

It thinks a border was requested and sets border="1"

Other details

  • Browser: Chrome 59 @ Linux, Mac, Windows; Edge
  • OS: Linux, Mac, Windows
  • Installed CKEditor plugins: standard presets

Comments

First time bug-poster, long-time user!

Behavior is the same in the nightly build standard editor.

This can be worked-around by breaking the border: tag apart into border-color, border-style, and border-width, which then doesn't change the border attribute.

@mlewand
Copy link
Contributor

mlewand commented Jun 27, 2017

AFAICS any value of border property (even 0px) results with setting a border to 1. Definitely an issue.

@mlewand mlewand added status:confirmed An issue confirmed by the development team. type:bug A bug. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jun 27, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 27, 2017

Also confirmed with edge so it's a cross browser, will add this information in original details. The for all of this is a simplified transformation in the table plugin.

@mlewand mlewand added the plugin:table The plugin which probably causes the issue. label Jun 27, 2017
@larsinsd
Copy link

Has this been fixed with 4.7.1?

@wojtekw92 wojtekw92 self-assigned this Jul 5, 2017
@wojtekw92 wojtekw92 mentioned this issue Jul 7, 2017
2 tasks
@f1ames f1ames added this to the 4.7.3 milestone Aug 21, 2017
@f1ames
Copy link
Contributor

f1ames commented Aug 21, 2017

@larsinsd We are targeting CKEditor 4.7.3, the fix was just merged to master branch so you can be sure it will be included in the next release.

@wojtekw92 wojtekw92 removed their assignment Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants