Update urls #1041

beatadelura · 2017-10-12T08:20:34Z

What is the purpose of this pull request?

Updating URLs.

I went through all files and checked/changed URLs. I left URLs in test files to avoid regression. Let me know, If you think, test files should be also changed.

There is one more URL to change: http://ckeditor.com/license, https://cksource.com/ckeditor/license/ - but it's under discussion.

Closes #1131.

AnnaTomanek · 2017-10-12T09:23:32Z

.github/SUPPORT.md

@@ -17,6 +17,6 @@ For more advanced needs (e.g. CKEditor integration in your products, or developm

 For more reading visit our supporting resources:

-* An extensive [CKEditor 4 documentation](http://docs.ckeditor.com/) with information about CKEditor features and configuration settings.
+* An extensive [CKEditor 4 documentation](https://docs.ckeditor.com/ckeditor4/latest/) with information about CKEditor features and configuration settings.


The link for documentation is: https://docs.ckeditor.com/ckeditor4/docs/, https://docs.ckeditor.com/ckeditor4/latest/ is the entry page that includes SDK etc. Since we have samples separately below, I'd use the direct documentation link.

AnnaTomanek · 2017-10-12T09:24:10Z

.github/ISSUE_TEMPLATE.md

@@ -3,7 +3,7 @@
 <!--
 Replace this comment with your issue type: Bug / Feature request / Other, please explain.

-Please **do not report security issues here**, use the contact form at http://cksource.com/contact instead.
+Please **do not report security issues here**, use the contact form at https://cksource.com/contact/ instead.


https://ckeditor.com/contact/

AnnaTomanek · 2017-10-12T09:24:36Z

.github/CONTRIBUTING.md

@@ -9,7 +9,7 @@ If you are preparing a pull request, see [Contributing Code and Providing Patche
 If you would like to contribute in any other way, you can consider the following actions:

 1. Create your own [plugins](http://docs.ckeditor.com/#!/guide/plugin_sdk_sample) or [skins](http://docs.ckeditor.com/#!/guide/skin_sdk_intro)
-and submit them to [CKEditor Add-Ons Repository](http://ckeditor.com/addons/plugins).
+and submit them to [CKEditor Add-Ons Repository](https://ckeditor.com/addons/plugins).


https://ckeditor.com/cke4/addons/plugins/

AnnaTomanek · 2017-10-12T09:25:06Z

core/config.js

@@ -319,7 +319,7 @@ CKEDITOR.config = {
 	 *
 	 * **Note:** The most recommended way to
 	 * [add CKEditor plugins](http://docs.ckeditor.com/#!/guide/dev_plugins) is through
-	 * [CKEditor Builder](http://ckeditor.com/builder). Read more in the
+	 * [CKEditor Builder](https://ckeditor.com/builder). Read more in the


https://ckeditor.com/cke4/builder

AnnaTomanek · 2017-10-12T09:25:27Z

core/creators/themedui.js

@@ -309,7 +309,7 @@ CKEDITOR.replaceClass = 'ckeditor';

 	/**
 	 * Gets the element that can be used to check the editor size. This method
-	 * is mainly used by the [Editor Resize](http://ckeditor.com/addon/resize) plugin, which adds
+	 * is mainly used by the [Editor Resize](https://ckeditor.com/addon/resize) plugin, which adds


https://ckeditor.com/cke4/addon/resize

AnnaTomanek · 2017-10-12T09:34:22Z

plugins/wysiwygarea/plugin.js

@@ -659,7 +659,7 @@ CKEDITOR.config.disableNativeTableHandles = true;
 * users can always reach the native context menu by holding the
 * *Ctrl* key when right-clicking if {@link #browserContextMenuOnCtrl}
 * is enabled or you are simply not using the
- * [context menu](http://ckeditor.com/addon/contextmenu) plugin.
+ * [context menu](https://ckeditor.com/addon/contextmenu) plugin.


https://ckeditor.com/cke4/addon/contextmenu

AnnaTomanek · 2017-10-12T09:35:06Z

samples/index.html

 			<li><a href="https://github.com/ckeditor/ckeditor-dev/issues">I found a bug</a></li>
 			<li><a href="http://github.com/ckeditor/ckeditor-dev" class="icon-pos-right icon-navigation-a-github">Fork CKEditor on GitHub</a></li>
 		</ul>
 		<ul class="navigation-a-right grid-width-30">
-			<li><a href="http://ckeditor.com/blog-list">CKEditor Blog</a></li>
+			<li><a href="https://ckeditor.com/blog-list">CKEditor Blog</a></li>


https://ckeditor.com/blog/

AnnaTomanek · 2017-10-12T09:35:41Z

samples/index.html

@@ -17,12 +17,12 @@
 <nav class="navigation-a">
 	<div class="grid-container">
 		<ul class="navigation-a-left grid-width-70">
-			<li><a href="http://ckeditor.com">Project Homepage</a></li>
+			<li><a href="https://ckeditor.com">Project Homepage</a></li>


https://ckeditor.com/ckeditor-4/

AnnaTomanek · 2017-10-12T09:36:47Z

samples/toolbarconfigurator/index.html

@@ -25,12 +25,12 @@
 <nav class="navigation-a">
 	<div class="grid-container">
 		<ul class="navigation-a-left grid-width-70">
-			<li><a href="http://ckeditor.com">Project Homepage</a></li>
+			<li><a href="https://ckeditor.com">Project Homepage</a></li>


https://ckeditor.com/ckeditor-4/

AnnaTomanek · 2017-10-12T09:37:01Z

samples/toolbarconfigurator/index.html

 			<li><a href="https://github.com/ckeditor/ckeditor-dev/issues">I found a bug</a></li>
 			<li><a href="http://github.com/ckeditor/ckeditor-dev" class="icon-pos-right icon-navigation-a-github">Fork CKEditor on GitHub</a></li>
 		</ul>
 		<ul class="navigation-a-right grid-width-30">
-			<li><a href="http://ckeditor.com/blog-list">CKEditor Blog</a></li>
+			<li><a href="https://ckeditor.com/blog-list">CKEditor Blog</a></li>


https://ckeditor.com/blog/

beatadelura · 2017-10-12T11:15:05Z

@AnnaTomanek Thanks for help and review! I changed requested files, PTAL.

There is one more thing, I found file CHANGES.md which should be also updated. I'm working on it, so I'll let you know when PR will be ready :)

beatadelura · 2017-10-12T12:08:33Z

@AnnaTomanek CHANGES.md updated. PTAL

AnnaTomanek · 2017-10-12T12:16:31Z

Just noticed that we also have links to API docs that changed their location... For example, https://docs.ckeditor.com/#!/api/CKEDITOR.focusManager-method-focus -> https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.focusManager-method-focus

Do we also want to change those? Should be easy enough...

beatadelura · 2017-10-16T09:28:59Z

@AnnaTomanek I changed it. PTAL :)

msamsel · 2017-11-03T14:01:06Z

@AnnaTomanek do you know a little bit more about this case? What kind/types of link we want to correct? Is there some kind of list (at least domains which should be corrected?).
Do you know also what's the status of http://ckeditor.com/license link? Is there some decision how it should looks like?

AnnaTomanek · 2017-11-06T07:25:58Z

We're leaving http://ckeditor.com/license as is, a correct redirect will be in place.

msamsel · 2017-11-06T09:28:54Z

I use https for license, as it is landing url regardless of using protocol.

msamsel · 2017-11-06T09:44:50Z

I've made additional url replacements. Some info:

I tried to avoid modify tests folder to not break any unit test.
Last 3 commits (c9a6933, e74f0d7, 7362194) are made manually
Other commits has followed replacements ( links might exist with some endings, which wasn't replace and should remain untouched ):

AnnaTomanek · 2017-11-06T11:49:16Z

Looks fine, I noticed two minor http://ckeditor.com cases in samples (enterkey and inlineall).

Also plenty of http://ckeditor.com and http://cksource.com in tests but I guess it's intentional, so let's leave it.

…n changelog.

msamsel · 2017-11-06T15:27:51Z

With tests folder is this problem, that changing it would require detail analyse of specific test. Firstly I change everything and as result I get failed test (mostly autoembed and link unit tests). It seems to be more secure to not update those tests.
Generally tests cases should not be traffic source for CKEditor page. Usually those links are inside editor, so are not clickable and does not redirect user nor tester.

I add those 2 missing CKEditor urls. I have no idea how I missed that :( I also rebase to actual major and update link in changelog.

beatadelura force-pushed the update_urls branch from 53c76e4 to a46a9e3 Compare October 12, 2017 08:36

AnnaTomanek suggested changes Oct 12, 2017

View reviewed changes

AnnaTomanek approved these changes Oct 12, 2017

View reviewed changes

beatadelura force-pushed the update_urls branch from 7392fd4 to a8af47b Compare October 12, 2017 12:01

AnnaTomanek added this to the 4.8.0 milestone Nov 3, 2017

AnnaTomanek assigned msamsel Nov 6, 2017

msamsel force-pushed the update_urls branch from 79df7b1 to 7362194 Compare November 6, 2017 09:37

beatadelura and others added 14 commits November 6, 2017 16:21

Updating urls.

e286693

Updating URLs.

158d6a7

Update URL in widget plugin.

455e734

Update URLs in CHANGES.md.

321343c

Changing doc urls in CHANGES.md file.

849766a

Changing doc urls.

59ac5bc

Modify licencse url to start from https

598285b

Modify docs url.

a0a0055

Modify sdk url.

c612135

Change addon link.

9bac5dd

Change dev.ckeditor.com link.

aac185e

Replace old license entry with new one.

3e2a319

Manual changes to changelog and SDK skin links.

65fa33e

Changes to links in About plugin.

b35664b

Adding 2 missing ckeditor url to start with https and updat one url i…

ba44570

…n changelog.

msamsel force-pushed the update_urls branch from 7362194 to ba44570 Compare November 6, 2017 15:24

f1ames self-assigned this Nov 7, 2017

f1ames merged commit 7f55904 into major Nov 7, 2017

f1ames deleted the update_urls branch November 7, 2017 12:51

msamsel mentioned this pull request Nov 15, 2017

Link in About Dialog points to CKEditor 3.x user's guide. #532

Closed

mlewand removed this from the 4.8.0 milestone Nov 24, 2017

msamsel restored the update_urls branch December 15, 2017 11:54

msamsel deleted the update_urls branch December 15, 2017 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update urls #1041

Update urls #1041

beatadelura commented Oct 12, 2017 •

edited by f1ames

Loading

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

AnnaTomanek Oct 12, 2017

beatadelura commented Oct 12, 2017

beatadelura commented Oct 12, 2017

AnnaTomanek commented Oct 12, 2017

beatadelura commented Oct 16, 2017

msamsel commented Nov 3, 2017

AnnaTomanek commented Nov 6, 2017

msamsel commented Nov 6, 2017 •

edited

Loading

msamsel commented Nov 6, 2017 •

edited

Loading

AnnaTomanek commented Nov 6, 2017

msamsel commented Nov 6, 2017

Update urls #1041

Update urls #1041

Conversation

beatadelura commented Oct 12, 2017 • edited by f1ames Loading

What is the purpose of this pull request?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beatadelura commented Oct 12, 2017

beatadelura commented Oct 12, 2017

AnnaTomanek commented Oct 12, 2017

beatadelura commented Oct 16, 2017

msamsel commented Nov 3, 2017

AnnaTomanek commented Nov 6, 2017

msamsel commented Nov 6, 2017 • edited Loading

msamsel commented Nov 6, 2017 • edited Loading

AnnaTomanek commented Nov 6, 2017

msamsel commented Nov 6, 2017

beatadelura commented Oct 12, 2017 •

edited by f1ames

Loading

msamsel commented Nov 6, 2017 •

edited

Loading

msamsel commented Nov 6, 2017 •

edited

Loading