Round offset to the nearest integer in tests

[Comandeer]

What is the purpose of this pull request?

Failing test fix

What changes did you make?

I added Math.ceil to some assertions as Firefox sometimes returns non-integers.

Closes #2141.

[mlewand]

Though it solves the issue on some setups, it still does not work everywhere.

For instance it doesn't pass for me in FF 60.0.2 (64-bit) @ Win 10.

The following gets reported:

Error details for tests/plugins/autocomplete/view

test get caret rect (inline)

Values should be equal.
Expected: 7 (number)
Actual:   8 (number)

test get caret rect with repositioned offset host (classic)

Values should be equal.
Expected: 7 (number)
Actual:   6.8000030517578125 (number)

test get caret rect with repositioned offset host (inline)

Values should be equal.
Expected: 7 (number)
Actual:   8 (number)

[mlewand]

The feature works correctly, the problem is with tests on FF. I suggest we ignore this for now and fix it correctly in next minor release.

[mlewand]

Some more insights on failing test - it fails only when run from the dashboard. It passes if ran individually.

It depends on screen resolution, it works when window.devicePixelRatio is 1.0 but fails if window.devicePixelRatio is 2.5.

Here's a dump of screen member:

availHeight: 824
​availLeft: 0
​availTop: 0
​availWidth: 1536
​colorDepth: 24
​height: 864
​left: 0
​mozOrientation: "landscape-primary"
​onmozorientationchange: null
​orientation: ScreenOrientation { type: "landscape-primary", angle: 0, onchange: null }
​pixelDepth: 24
​top: 0
width: 1536

[Comandeer]

Simple change from Math.ceil to Math.round seems to fix the error. I've also rebased onto latest next.