Localization of the smiley's titles. #222
Conversation
Currently localized English and Russian. Any other languages welcome
I do not like the Smiley plugin because I do not want see a dialog with the smileys list. Instead I want see all smileys into toolbar. I have added a Smileys toolbar row to do so.
I want manipulate any row of the toolbar in my project. For example I
want hide/show any row of the toolbar any time. I need have access to
any row of the toolbar to do so. I do not want use row id for access to
row of the toolbar because id is uncomfortable. For example currently
the element of the toolbar row with name "document" is:
<span id="cke_15" class="cke_toolbar" aria-labelledby="cke_15_label"
role="toolbar" >
The id="cke_15" is uncomfortable for get the "document" element. I want
add the name="document" attribute:
<span id="cke_15" class="cke_toolbar" aria-labelledby="cke_15_label"
role="toolbar" name="document">
Now I can get this row very easy:
var rowDocument = document.getElementsByName('document')[0];
Please see an example of manipulation of a row of the toolbar in the
index.html page. There a user can hide/show the Smileys toolbar row by
clicking the "Show/hide the Smileys toolbar row" button
|
Thank you for your pull request. However we'll strip There were few changes needed to be made to improve your PR:
As for any other lang file than Merged with 6b26ded. |
|
Unfortunately we had to revert your pull request. Let me explain the reason for that with an example. Let's say that there is some English blog, and it uses CKE for comments fromatting. If you access it with a Russian browser (assuming that English UI lang is not forced) CKE will automatically switch UI to Russian version. In this case if you'll put some smileys, it will use Russian localization, which will be confusing for different language users. I'm sorry for not catching this fact during the initial review. As for now the best way to localize your smileys is in fact config.smiley_descriptions property if you want them to be localized in your site. We can still use your localization for UI-only translations, but it's too late to include it to 4.5.5 now. |
Currently localized English and Russian. Any other languages welcome