Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Localization of the smiley's titles. #222
Thank you for your pull request. However we'll strip
There were few changes needed to be made to improve your PR:
Merged with 6b26ded.
Unfortunately we had to revert your pull request. Let me explain the reason for that with an example.
Let's say that there is some English blog, and it uses CKE for comments fromatting. If you access it with a Russian browser (assuming that English UI lang is not forced) CKE will automatically switch UI to Russian version. In this case if you'll put some smileys, it will use Russian localization, which will be confusing for different language users.
I'm sorry for not catching this fact during the initial review. As for now the best way to localize your smileys is in fact config.smiley_descriptions property if you want them to be localized in your site. We can still use your localization for UI-only translations, but it's too late to include it to 4.5.5 now.