Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide working example for "Try it out" link on our npm package page. #50

Closed
f1ames opened this issue Feb 22, 2016 · 3 comments
Closed

Comments

@f1ames
Copy link
Contributor

f1ames commented Feb 22, 2016

There is "Try it out Test ckeditor in your browser." link/box in ckeditor package page which uses tonicdev.com playground/sandbox to show packages examples in browser.
For CKEditor it does not work out of the box so we should provide working example.

I posted an issue on npm/newww, asking how it should be done correctly for frontend packages like CKEditor, see https://github.com/npm/newww/issues/1891.

@boucher
Copy link

boucher commented Feb 23, 2016

I've opened a pull request here: #51

@mlewand
Copy link
Contributor

mlewand commented Feb 23, 2016

@boucher thanks a lot! We'll check it soon! :)

@f1ames
Copy link
Contributor Author

f1ames commented Aug 26, 2020

Closing as not really relevant anymore. Also from what I see Tonic evolved into RunKit so the related PR may no longer work after such a long time.

@f1ames f1ames closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants