Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Consumption of Non-Webpacked Source Code #17

Closed
sbulley09 opened this issue Mar 8, 2021 · 3 comments · Fixed by #18
Closed

Support Consumption of Non-Webpacked Source Code #17

sbulley09 opened this issue Mar 8, 2021 · 3 comments · Fixed by #18
Assignees
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@sbulley09
Copy link

Are you reporting a feature request or a bug?

Feature Request

Request Details

Currently, the only method of consumption is via the webpacked bundle in the dist folder. This webpack bundle includes a polyfill babel polyfill set up via the usage method. This ends up adding a polyfill for Promises but not for the 'finally' functionality of promises since those are not used within the code. One of our solutions relies on a promise polyfill which is a different polyfill than the provided by babel.

Since the incomplete babel polyfill is loaded first without all the functionality, it doesn't get overwritten by our polypill and thus we end up with the 'finally' functionality missing. As a work around, we've copied the source code into our own project which allows us to use our internal strategy of building projects. This comes with the downside of having to continually update our internal fork over time and maintain that ourselves. It would be ideal for us to be able to consume the non-webpacked source and be able to apply our own polyfills as needed.

@sculpt0r
Copy link
Contributor

Hi @sbulley09 ,

Thank you for the proposal. At this point I can tell that we won't work on such a solution - so I close this issue. Please, notice that we have to provide a complete solution that works in many different environments.

@sculpt0r sculpt0r added resolution:wontfix The issue is valid, however, CKSource does not plan to fix it. type:feature A feature request. labels Mar 10, 2021
@sculpt0r
Copy link
Contributor

@sbulley09 base on ckeditor/ckeditor4-react#180 (comment) I also reopen this issue.

@sculpt0r sculpt0r reopened this Mar 11, 2021
@sculpt0r sculpt0r added status:confirmed An issue confirmed by the development team. size:? and removed resolution:wontfix The issue is valid, however, CKSource does not plan to fix it. labels Mar 11, 2021
@MMMalik
Copy link
Contributor

MMMalik commented May 6, 2021

Another downside of using webpack and including polyfills is a huge increase in bundle sizes. I would estimate the true size of ckeditor4-integrations-common to be just a few kilobytes when in fact this package (even minified) weighs around 21 KB. There is a huge potential gain in terms of bundle sizes for downstream packages and by consequence end-users.

Since only integration libraries depend on this package, then fix should be easy to coordinate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants