Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 Compatibility #75

Closed
cranberrieman opened this issue Dec 8, 2020 · 5 comments · Fixed by #81
Closed

IE 11 Compatibility #75

cranberrieman opened this issue Dec 8, 2020 · 5 comments · Fixed by #81
Assignees
Labels
regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@cranberrieman
Copy link

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Plugin version 1.2.0
  2. Use with command: import CKEditor from 'ckeditor4-vue/dist/legacy.js'
  3. Check in IE 11

Expected result

Proper work of editor

Actual result

Syntax error in build.
Error leads me to webpack://ckeditor/node_modules/ckeditor4-integrations-common/src/getEditorNamespace.js:47

Other details

With version 1.1.0 it works fine

@Dumluregn
Copy link
Collaborator

Unfortunately I can confirm this issue. We introduced this regression in #66. The ckeditor4-integrations-common package isn't transpiled to ES5, which means we try to use promises in IE11. I'm not sure if it can be fixed by modifying the webpack config or ckeditor4-integrations-common should be exported in the transpiled form.

Also it seems like a good idea to move on with #9.

@Dumluregn Dumluregn added regression This issue is a regression. size:M status:confirmed An issue confirmed by the development team. type:bug A bug. labels Dec 9, 2020
@jacekbogdanski
Copy link
Member

jacekbogdanski commented Dec 14, 2020

The fix is quite simple, we need to add additional processing to webpack, similar to what we have in other integrations, e.g. Vue - https://github.com/ckeditor/ckeditor4-vue/blob/master/webpack.config.js#L17-L29 (but as a part of the standard conversion).

@sculpt0r
Copy link
Contributor

Blocked by: ckeditor/ckeditor4-integrations-common#12

@sculpt0r
Copy link
Contributor

Since publish problem was solved: ckeditor/ckeditor4-integrations-common#12 (comment)

I unblock this issue, and move to failing tests on IE11.

@sculpt0r sculpt0r removed the status:blocked An issue which development is blocked by another issue (internal or external one). label Jan 26, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
5 participants