Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not keep the <font>tag when saving #1115

Closed
topliu88 opened this issue Nov 3, 2017 · 1 comment
Closed

Can not keep the <font>tag when saving #1115

topliu88 opened this issue Nov 3, 2017 · 1 comment
Assignees
Labels
plugin:font The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@topliu88
Copy link

topliu88 commented Nov 3, 2017

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

No

Provide detailed reproduction steps (if any)

  1. Set config to:
config.fontSize_sizes = '1/1;2/2;3/3;4/4;5/5;6/6;7/7;';

config.font_style = {
	element: 'font',
	attributes: {'face': '#(family)'},
	overrides: [{
		element: 'font', attributes: {'face': null}
	}]
};
config.fontSize_style = {
	element: 'font',
	attributes: {'size': '#(size)'},
	overrides: [{
		element: 'font', attributes: {'size': null}
	}]
};

config.extraAllowedContent = 'font[*]';
  1. Set font size to 4 for a string.
  2. Saving the form, the CKEditor.getdata() will wrongly convert "font" to "span".

Expected result

The "font" tags are kept.

Actual result

"font" tags were wrongly converted to "span"

Other details

Till CKEditor 4.5.11 this config works fine.

  • Browser: All
  • OS: All
  • CKEditor version: 4.6.0
  • Installed CKEditor plugins: font
@f1ames f1ames added plugin:font The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Dec 11, 2017
@f1ames
Copy link
Contributor

f1ames commented Dec 11, 2017

Can be reproduced here: https://codepen.io/f1ames/pen/goYxgz

@mlewand mlewand added this to the Backlog milestone Dec 29, 2017
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. regression This issue is a regression. labels Dec 29, 2017
@msamsel msamsel self-assigned this Aug 16, 2018
@Comandeer Comandeer modified the milestones: Backlog, 4.10.1 Aug 23, 2018
@mlewand mlewand changed the title Can not keep the <font>tag when saving, version 4.6.2 Can not keep the <font>tag when saving Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:font The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants