Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File browser plugin should use XHR requests by default #1365

Closed
mlewand opened this issue Dec 20, 2017 · 0 comments · Fixed by #1507
Closed

File browser plugin should use XHR requests by default #1365

mlewand opened this issue Dec 20, 2017 · 0 comments · Fixed by #1507
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:filebrowser The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.9.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Dec 20, 2017 •
edited by AnnaTomanek
Loading

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

In issue #643 we added support for uploading files in the File Browser plugin using XHR requests, which allows to customize HTTP headers or keep track of the upload progress.

Since we couldn't enable it by default in a minor release as it's a backward incompatible change, we had to wait with the switch for the next major release.

So as a solution to this issue the default handling should be set to the new XHR method.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.8.1
  • Installed CKEditor plugins: filebrowser,filetools
@mlewand mlewand added plugin:filebrowser The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Dec 20, 2017
@mlewand mlewand added this to the 4.9.0 milestone Dec 20, 2017
@jswiderski jswiderski mentioned this issue Dec 20, 2017
Closed
@msamsel msamsel mentioned this issue Jan 29, 2018
Merged
2 tasks
This was referenced May 9, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:filebrowser The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging a pull request may close this issue.

Make XHR defualt option to upload a file ckeditor/ckeditor4
1 participant
@mlewand