Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'uploadWidgetDefinition.onAbort' method is not called when loader is aborted #1454

Closed
f1ames opened this issue Jan 15, 2018 · 0 comments · Fixed by #1463
Closed

'uploadWidgetDefinition.onAbort' method is not called when loader is aborted #1454

f1ames opened this issue Jan 15, 2018 · 0 comments · Fixed by #1463
Assignees
Labels
plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@f1ames
Copy link
Contributor

f1ames commented Jan 15, 2018

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

According to SDK there are few on* methods in uploadWidgetDefinition which are fired when loader status changes.

However, even if onAbort is defined in uploadWidgetDefinition it is not fired when upload is aborted (widget removed or editor switched to Source mode during upload).

Quick reproduction steps

  1. Go to https://sdk.ckeditor.com/samples/fileupload.html.
  2. Paste in the browser dev console:
CKEDITOR.instances.editor2.widgets.registered.uploadimage.onAbort = function() { console.log( 'abort' ) }
  1. Drop image into second editor on page.
  2. Delete image widget or switch to source mode during upload.

Proper reproduction steps

uploadWidgetDefinition containing onAbort method is needed. Easy way may be to adjust uploadimage plugin (by adding onAbort method) and then test it on e.g. /tests/plugins/uploadwidget/manual/image2 manual test.

Expected result

onAbort method from uploadWidgetDefinition is fired when uploading aborted.

Actual result

onAbort method from uploadWidgetDefinition is not fired when uploading aborted.

Other details

  • Browser: All (tested on Chrome and FF)
  • OS: All
  • CKEditor version: -
  • Installed CKEditor plugins: uploadwidget
@f1ames f1ames added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:uploadwidget The plugin which probably causes the issue. labels Jan 15, 2018
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Jan 16, 2018
@jacekbogdanski jacekbogdanski self-assigned this Aug 31, 2018
@Comandeer Comandeer added this to the 4.11.0 milestone Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
4 participants