Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovering dropdown on the end of balloontoolbar changes its size causing flickering #1682

Closed
f1ames opened this issue Feb 15, 2018 · 1 comment
Closed

Hovering dropdown on the end of balloontoolbar changes its size causing flickering #1682

f1ames opened this issue Feb 15, 2018 · 1 comment
Assignees
@jacekbogdanski
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Feb 15, 2018

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Run tests/plugins/balloontoolbar/manual/balloontoolbar test.
  2. Click on any fragment with red border to open balloon toolbar.
  3. Hover Styles dropdown.

Expected result

Dropdown is hovered, balloon toolbar size does not change.

Actual result

Dropdown is hovered, balloon toolbar size change and arrow changes its position.

feb-15-2018 13-54-57

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.8.0
  • Installed CKEditor plugins: balloontoolbar
@f1ames f1ames added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:balloontoolbar The plugin which probably causes the issue. labels Feb 15, 2018
@mlewand
Copy link
Contributor

mlewand commented Feb 16, 2018 •
edited

I reproduced the issue on Chrome / FF / Edge (didn't try IE). I can see that the important factor here is high pixel density setting, if you're using window.devicePixelRatio >= 2 then the issue occurs.

The bug was not reproducible for me in case of a 1:1 pixel mapping.

Also menubuttonw was causing same (similar?) issue for me on FF, where triangle, whole toolbar and the icon would flicker:

mouseoverflicker

@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Feb 16, 2018
@mlewand mlewand added this to the Backlog milestone Feb 16, 2018
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Feb 16, 2018
@jacekbogdanski jacekbogdanski self-assigned this Sep 5, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Sep 5, 2018
Merged
2 tasks
@Comandeer Comandeer modified the milestones: Backlog, 4.10.2 Sep 29, 2018
@mlewand mlewand modified the milestones: 4.10.2, 4.11.0 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
4 participants
@f1ames @Comandeer @mlewand @jacekbogdanski