Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraPlugins configuration option should allow whitespaces between values #1712

Closed
arist0tl3 opened this issue Feb 22, 2018 · 3 comments
Closed
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone

Comments

@arist0tl3
Copy link

Feature Request

After pulling my hair out trying to debug why I could only add one external plugin at a time, I realized that the config option extraPlugins doesn't accept whitespace between values.

Not a huge deal, but no other config options seem to have that requirement, and there is no documentation around this required format.

I feel like this is confusing, as removePlugins is fine with whitespace, but extraPlugins isnt:

image

Accepting whitespace would be the better solution, but a note in the docs would be the quicker one, I'm assuming.

Happy to open a PR to trim the whitespace.

@f1ames f1ames added type:feature A feature request. status:confirmed An issue confirmed by the development team. changelog:api A changelog entry should be put in the API section of the changelog. labels Feb 23, 2018
@f1ames
Copy link
Contributor

f1ames commented Feb 23, 2018

Thanks for reporting @arist0tl3! I can confirm it works this way and it will be good to keep removePlugins and extraPlugins settings consistent (so they both handle whitespaces).

If you feel like creating a PR, it would be great (you may want to check contributing guide)!

Btw. the code responsible for this behaviour should be probably somewhere here:
https://github.com/ckeditor/ckeditor-dev/blob/53ac710582ff47dd63ec4368cfd752db5bee6e28/core/editor.js#L499-L505

@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Mar 7, 2018
@jacekbogdanski jacekbogdanski changed the title Undocumented extraPlugins format extraPlugins configuration option should allow whitespaces between values Mar 8, 2018
@Comandeer
Copy link
Member

Comandeer commented Mar 15, 2018

There is also third, very similar option to extraPlugins and removePluginsplugins. The whole handling logic for these three options is in one place, so I'd broaden the scope of issue and fix also whitespaces in plugins option.

@Comandeer Comandeer added this to the 4.10.0 milestone Apr 3, 2018
@Comandeer
Copy link
Member

Closed in #1762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

4 participants