Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace caretposition plugin with range.getClientRects function #1933

Closed
jacekbogdanski opened this issue Apr 27, 2018 · 1 comment
Closed

Replace caretposition plugin with range.getClientRects function #1933

jacekbogdanski opened this issue Apr 27, 2018 · 1 comment
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:autocomplete The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.10.0

Comments

@jacekbogdanski
Copy link
Member

Are you reporting a feature request or a bug?

Feature request

caretposition plugin does the same job as CKEDITOR.dom.range#getClientRects function. We should replace this plugin with existing API to avoid code duplication. Note that we should probably wait with this issue until CKEDITOR.dom.range#getClientRects function will be stable. See #1930,
#1925 for more details.

Expected result

autocomplete plugin uses CKEDITOR.dom.range#getClientRects function to resolve caret position.

Actual result

autocomplete plugin uses CKEDITOR.dom.selection#getCaretPosition function to resolve caret position. This function is added by caretpostion plugin if available.

Other details

  • Browser: any
  • OS: any
  • CKEditor version: 4.10.0
  • Installed CKEditor plugins: autocomplete, caretposition
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:autocomplete The plugin which probably causes the issue. labels Apr 27, 2018
@jacekbogdanski jacekbogdanski added the changelog:skip A changelog entry should not be added for a given issue. label Jun 22, 2018
@jacekbogdanski jacekbogdanski added this to the 4.10.0 milestone Jun 22, 2018
@jacekbogdanski
Copy link
Member Author

This issue was resolved with #1751 in 4.10.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:autocomplete The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.10.0
Development

No branches or pull requests
1 participant
@jacekbogdanski