Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse code in tools.throttle and tools.eventsBuffer #2045

Closed
mlewand opened this issue Jun 1, 2018 · 1 comment · Fixed by brandcast/ckeditor-dev#1
Closed

Reuse code in tools.throttle and tools.eventsBuffer #2045

mlewand opened this issue Jun 1, 2018 · 1 comment · Fixed by brandcast/ckeditor-dev#1
Assignees
@jacekbogdanski
Labels
changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Jun 1, 2018

Type of report

Task

Provide description of the task

In #1993 we added throttling function, however it introduced some copy'n'pasted code as mentioned in review comment #1996 (review).

The code should be reused.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.10.0
@mlewand mlewand added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. changelog:skip A changelog entry should not be added for a given issue. labels Jun 1, 2018
@mlewand mlewand mentioned this issue Jun 1, 2018
Merged
2 tasks
@jacekbogdanski jacekbogdanski mentioned this issue Jun 7, 2018
Merged
@jacekbogdanski jacekbogdanski self-assigned this Jul 17, 2018
@jacekbogdanski jacekbogdanski added status:confirmed An issue confirmed by the development team. and removed status:confirmed An issue confirmed by the development team. labels Jul 17, 2018
@mlewand mlewand added this to the 4.11.0 milestone Sep 1, 2018
@mlewand mlewand modified the milestones: 4.11.0, Backlog Oct 17, 2018
@jacekbogdanski
Copy link
Member

Closed by #2060.

@mlewand mlewand modified the milestones: Backlog, 4.11.0 Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

#2045 remove this check brandcast/ckeditor-dev
2 participants
@mlewand @jacekbogdanski