Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link plugin should better support email addresses #2138

Closed
msamsel opened this issue Jun 22, 2018 · 0 comments · Fixed by #3254
Closed

Link plugin should better support email addresses #2138

msamsel opened this issue Jun 22, 2018 · 0 comments · Fixed by #3254
Assignees
@Dumluregn
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.13.0

Comments

@msamsel
Copy link
Contributor

msamsel commented Jun 22, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor
  2. Add new link
  3. Switch to email link
  4. Try to add user with email address: john?doe@example.com
  5. Save changes
  6. Edit link

Expected result

Proper email address is displayed

Actual result

Email is cut after question mark, which should be escaped.

Note:

According to [RFC5322], the characters "?", "&", and even "%" may
occur in addr-specs. The fact that they are reserved characters is
not a problem: those characters may appear in 'mailto' URIs -- they
just may not appear in unencoded form. The standard URI encoding
mechanisms ("%" followed by a two-digit hex number) MUST be used in
these cases.

Source: https://tools.ietf.org/html/rfc6068

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.9.2
  • Installed CKEditor plugins: Link
@msamsel msamsel added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:link The plugin which probably causes the issue. labels Jun 22, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Jun 22, 2018
@Dumluregn Dumluregn self-assigned this Jul 3, 2019
This was referenced Jul 9, 2019
Open
Merged
@f1ames f1ames changed the title Link plugin should better support email adresses Link plugin should better support email addresses Jul 30, 2019
@Dumluregn Dumluregn mentioned this issue Aug 9, 2019
Merged
2 tasks
@f1ames f1ames added this to the 4.13.0 milestone Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.13.0
Development

Successfully merging a pull request may close this issue.

Fix for: Link plugin should better support email addresses ckeditor/ckeditor4
4 participants
@f1ames @mlewand @msamsel @Dumluregn